This is an automated email from the ASF dual-hosted git repository.
erikrit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 231c2b3 chore: fix add datasource help string (#10129)
231c2b3 is described below
commit 231c2b395ddb2304d3325f96f60ee811bf3eca47
Author: Erik Ritter <erik.rit...@airbnb.com>
AuthorDate: Mon Jun 22 07:51:50 2020 -0700
chore: fix add datasource help string (#10129)
---
.../src/addSlice/AddSliceContainer.jsx | 46 ++++++++++++----------
1 file changed, 25 insertions(+), 21 deletions(-)
diff --git a/superset-frontend/src/addSlice/AddSliceContainer.jsx
b/superset-frontend/src/addSlice/AddSliceContainer.jsx
index 69fe296..70a3ca0 100644
--- a/superset-frontend/src/addSlice/AddSliceContainer.jsx
+++ b/superset-frontend/src/addSlice/AddSliceContainer.jsx
@@ -87,29 +87,33 @@ export default class AddSliceContainer extends
React.PureComponent {
<Panel.Body>
<div>
<p>{t('Choose a datasource')}</p>
- <div style={styleSelectWidth}>
- <Select
- clearable={false}
- ignoreAccents={false}
- name="select-datasource"
- onChange={this.changeDatasource}
- options={this.props.datasources}
- placeholder={t('Choose a datasource')}
- style={styleSelectWidth}
- value={this.state.datasourceValue}
- width={600}
- />
- </div>
- <p className="text-muted">
+ <p>
+ <div style={styleSelectWidth}>
+ <Select
+ clearable={false}
+ ignoreAccents={false}
+ name="select-datasource"
+ onChange={this.changeDatasource}
+ options={this.props.datasources}
+ placeholder={t('Choose a datasource')}
+ style={styleSelectWidth}
+ value={this.state.datasourceValue}
+ width={600}
+ />
+ </div>
+ </p>
+ <span className="text-muted">
{t(
- 'If the datasource you are looking for is not ' +
- 'available in the list, ' +
- 'follow the instructions on the how to add it on the ',
- )}
- <a href="https://superset.apache.org/tutorial.html";>
- {t('Superset tutorial')}
+ 'If the datasource you are looking for is not available in
the list, follow the instructions on how to add it in the Superset tutorial.',
+ )}{' '}
+ <a
+
href="https://superset.apache.org/tutorial.html#adding-a-new-table";
+ rel="noopener noreferrer"
+ target="_blank"
+ >
+ <i className="fa fa-external-link" />
</a>
- </p>
+ </span>
</div>
<br />
<div>
