This is an automated email from the ASF dual-hosted git repository. villebro pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push: new 6a8f441 fix: make auth for hive optional (#10172) 6a8f441 is described below commit 6a8f441d5488c4580a819dc038ff0b02822094e1 Author: Hendrik Schultze <0xbadba...@users.noreply.github.com> AuthorDate: Mon Jun 29 06:40:24 2020 +0200 fix: make auth for hive optional (#10172) * fix: make auth for hive optional This will make allow the admin to setup a root connection which can be impersonated. * style: black lint conform * style: clean up unnecessary condition expansion --- superset/db_engine_specs/hive.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/superset/db_engine_specs/hive.py b/superset/db_engine_specs/hive.py index 952f734..c8a07a9 100644 --- a/superset/db_engine_specs/hive.py +++ b/superset/db_engine_specs/hive.py @@ -437,14 +437,9 @@ class HiveEngineSpec(PrestoEngineSpec): url = make_url(uri) backend_name = url.get_backend_name() - # Must be Hive connection, enable impersonation, and set param + # Must be Hive connection, enable impersonation, and set optional param # auth=LDAP|KERBEROS - if ( - backend_name == "hive" - and "auth" in url.query.keys() - and impersonate_user is True - and username is not None - ): + if backend_name == "hive" and impersonate_user and username is not None: configuration["hive.server2.proxy.user"] = username return configuration