[incubator-superset] branch master updated: build: enable Cypress tests for visualizations (#10206)

[yjc]

This is an automated email from the ASF dual-hosted git repository.

yjc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 538f7e0  build: enable Cypress tests for visualizations (#10206)
538f7e0 is described below

commit 538f7e0f732a7cab3a9de26d18fb665e8c12a24f
Author: Jesse Yang <jesse.y...@airbnb.com>
AuthorDate: Tue Jun 30 17:10:17 2020 -0700

    build: enable Cypress tests for visualizations (#10206)
---
 .github/workflows/bashlib.sh                                         | 2 +-
 .../cypress/integration/explore/visualizations/bubble.test.js        | 5 ++++-
 .../cypress/integration/explore/visualizations/table.test.js         | 2 ++
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/bashlib.sh b/.github/workflows/bashlib.sh
index 5f96359..54c90f9 100644
--- a/.github/workflows/bashlib.sh
+++ b/.github/workflows/bashlib.sh
@@ -189,7 +189,7 @@ cypress-run-all() {
   nohup flask run --no-debugger -p $port > "$flasklog" 2>&1 < /dev/null &
   local flaskProcessId=$!
 
-  cypress-run "*/*"
+  cypress-run "*/**/*"
 
   # Upload code coverage separately so each page can have separate flags
   # -c will clean existing coverage reports, -F means add flags
diff --git 
a/superset-frontend/cypress-base/cypress/integration/explore/visualizations/bubble.test.js
 
b/superset-frontend/cypress-base/cypress/integration/explore/visualizations/bubble.test.js
index 1b44919..68ee5fd 100644
--- 
a/superset-frontend/cypress-base/cypress/integration/explore/visualizations/bubble.test.js
+++ 
b/superset-frontend/cypress-base/cypress/integration/explore/visualizations/bubble.test.js
@@ -57,7 +57,10 @@ describe('Visualization > Bubble', () => {
     cy.route('POST', '/superset/explore_json/**').as('getJson');
   });
 
-  it('should work', () => {
+  // Number of circles are pretty unstable when there are a lot of circles
+  // Since main functionality is already covered in fitler test below,
+  // skip this test untill we find a solution.
+  it.skip('should work', () => {
     verify(BUBBLE_FORM_DATA);
     // number of circles = 214 rows
     cy.get('.chart-container svg .nv-point-clips circle').should(
diff --git 
a/superset-frontend/cypress-base/cypress/integration/explore/visualizations/table.test.js
 
b/superset-frontend/cypress-base/cypress/integration/explore/visualizations/table.test.js
index d9c92d3..2212d28 100644
--- 
a/superset-frontend/cypress-base/cypress/integration/explore/visualizations/table.test.js
+++ 
b/superset-frontend/cypress-base/cypress/integration/explore/visualizations/table.test.js
@@ -103,6 +103,7 @@ describe('Visualization > Table', () => {
   it('Test table with columns and row limit', () => {
     const formData = {
       ...VIZ_DEFAULTS,
+      query_mode: 'raw',
       all_columns: ['name'],
       metrics: [],
       row_limit: 10,
@@ -117,6 +118,7 @@ describe('Visualization > Table', () => {
 
     const formData = {
       ...VIZ_DEFAULTS,
+      query_mode: 'raw',
       all_columns: ['name', 'state', 'ds', 'num'],
       metrics: [],
       row_limit: limit,