svn commit: r1000382 - in /synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons: evaluators/Parser.java executors/MultiPriorityBlockingQueue.java util/TemporaryData.java

[hiranya]

Author: hiranya
Date: Thu Sep 23 09:39:41 2010
New Revision: 1000382

URL: http://svn.apache.org/viewvc?rev=1000382&view=rev
Log:
Refactoring


Modified:
    
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Parser.java
    
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/executors/MultiPriorityBlockingQueue.java
    
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/util/TemporaryData.java

Modified: 
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Parser.java
URL: 
http://svn.apache.org/viewvc/synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Parser.java?rev=1000382&r1=1000381&r2=1000382&view=diff
==============================================================================
--- 
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Parser.java
 (original)
+++ 
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/evaluators/Parser.java
 Thu Sep 23 09:39:41 2010
@@ -97,14 +97,6 @@ public class Parser {
     }
 
     /**
-     * Set the Conditions
-     * @param conditions <code>array</code> of conditions
-     */
-    public void setConditions(Condition[] conditions) {
-        this.conditions = conditions;
-    }
-
-    /**
      * Build the parser from a given XML
      *
      * @param conditions set of conditions

Modified: 
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/executors/MultiPriorityBlockingQueue.java
URL: 
http://svn.apache.org/viewvc/synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/executors/MultiPriorityBlockingQueue.java?rev=1000382&r1=1000381&r2=1000382&view=diff
==============================================================================
--- 
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/executors/MultiPriorityBlockingQueue.java
 (original)
+++ 
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/executors/MultiPriorityBlockingQueue.java
 Thu Sep 23 09:39:41 2010
@@ -399,11 +399,11 @@ public class MultiPriorityBlockingQueue<
         final ReentrantLock lock = this.lock;
         lock.lock();
         try {
-            String s = "";
+            StringBuffer s = new StringBuffer();
             for (InternalQueue<E> internalQueue : queues) {
-                s += internalQueue.toString();
+                s.append(internalQueue.toString());
             }
-            return s;
+            return s.toString();
         } finally {
             lock.unlock();
         }

Modified: 
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/util/TemporaryData.java
URL: 
http://svn.apache.org/viewvc/synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/util/TemporaryData.java?rev=1000382&r1=1000381&r2=1000382&view=diff
==============================================================================
--- 
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/util/TemporaryData.java
 (original)
+++ 
synapse/trunk/java/modules/commons/src/main/java/org/apache/synapse/commons/util/TemporaryData.java
 Thu Sep 23 09:39:41 2010
@@ -1,6 +1,7 @@
 package org.apache.synapse.commons.util;
 
 import org.apache.commons.io.IOUtils;
+import org.apache.commons.io.FileUtils;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 
@@ -355,7 +356,7 @@ public class TemporaryData {
             if (log.isDebugEnabled()) {
                 log.debug("Deleting temporary file " + temporaryFile);
             }
-            temporaryFile.delete();
+            FileUtils.deleteQuietly(temporaryFile);
         }
     }
 
@@ -364,7 +365,7 @@ public class TemporaryData {
     protected void finalize() throws Throwable {
         if (temporaryFile != null) {
             log.warn("Cleaning up unreleased temporary file " + temporaryFile);
-            temporaryFile.delete();
+            FileUtils.deleteQuietly(temporaryFile);
         }
     }
 }