This is an automated email from the ASF dual-hosted git repository. ilgrosso pushed a commit to branch 2_0_X in repository https://gitbox.apache.org/repos/asf/syncope.git
commit 5b8846b2ac7dd48523bd03e73f714c3584c72c0e Author: Francesco Chicchiriccò <[email protected]> AuthorDate: Fri Nov 2 11:03:06 2018 +0100 Small optimimzation --- .../src/main/java/org/apache/syncope/core/logic/RealmLogic.java | 8 ++------ .../provisioning/java/pushpull/DefaultRealmPullResultHandler.java | 8 ++------ 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/core/logic/src/main/java/org/apache/syncope/core/logic/RealmLogic.java b/core/logic/src/main/java/org/apache/syncope/core/logic/RealmLogic.java index 54ac004..dcb5494 100644 --- a/core/logic/src/main/java/org/apache/syncope/core/logic/RealmLogic.java +++ b/core/logic/src/main/java/org/apache/syncope/core/logic/RealmLogic.java @@ -127,9 +127,7 @@ public class RealmLogic extends AbstractTransactionalLogic<RealmTO> { Realm realm = realmDAO.save(binder.create(parent, realmTO)); PropagationByResource propByRes = new PropagationByResource(); - for (String resource : realm.getResourceKeys()) { - propByRes.add(ResourceOperation.CREATE, resource); - } + propByRes.addAll(ResourceOperation.CREATE, realm.getResourceKeys()); List<PropagationTaskTO> tasks = propagationManager.createTasks(realm, propByRes, null); PropagationReporter propagationReporter = taskExecutor.execute(tasks, false); @@ -192,9 +190,7 @@ public class RealmLogic extends AbstractTransactionalLogic<RealmTO> { } PropagationByResource propByRes = new PropagationByResource(); - for (String resource : realm.getResourceKeys()) { - propByRes.add(ResourceOperation.DELETE, resource); - } + propByRes.addAll(ResourceOperation.DELETE, realm.getResourceKeys()); List<PropagationTaskTO> tasks = propagationManager.createTasks(realm, propByRes, null); PropagationReporter propagationReporter = taskExecutor.execute(tasks, false); diff --git a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultRealmPullResultHandler.java b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultRealmPullResultHandler.java index 3be6554..5c63133 100644 --- a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultRealmPullResultHandler.java +++ b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultRealmPullResultHandler.java @@ -236,9 +236,7 @@ public class DefaultRealmPullResultHandler Realm realm = realmDAO.save(binder.create(profile.getTask().getDestinatioRealm(), realmTO)); PropagationByResource propByRes = new PropagationByResource(); - for (String resource : realm.getResourceKeys()) { - propByRes.add(ResourceOperation.CREATE, resource); - } + propByRes.addAll(ResourceOperation.CREATE, realm.getResourceKeys()); if (unmatchingRule == UnmatchingRule.ASSIGN) { List<PropagationTaskTO> tasks = propagationManager.createTasks(realm, propByRes, null); taskExecutor.execute(tasks, false); @@ -609,9 +607,7 @@ public class DefaultRealmPullResultHandler } PropagationByResource propByRes = new PropagationByResource(); - for (String resource : realm.getResourceKeys()) { - propByRes.add(ResourceOperation.DELETE, resource); - } + propByRes.addAll(ResourceOperation.DELETE, realm.getResourceKeys()); List<PropagationTaskTO> tasks = propagationManager.createTasks(realm, propByRes, null); taskExecutor.execute(tasks, false);
