This is an automated email from the ASF dual-hosted git repository. baunsgaard pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/systemds.git
commit 0e2e7846fdcc4ab0e0aff0f0b770bc2d568a8dea Author: Sebastian Baunsgaard <[email protected]> AuthorDate: Tue Oct 17 13:15:23 2023 +0200 [MINOR] Remove overwriting logs This commit remove the instances of overwriting logging that are left, and that should be overwritten via the log4j.properties file. --- .../org/apache/sysds/hops/ipa/InterProceduralAnalysis.java | 13 +------------ .../java/org/apache/sysds/hops/rewrite/ProgramRewriter.java | 12 +----------- src/main/java/org/apache/sysds/lops/LopProperties.java | 2 +- .../java/org/apache/sysds/parser/ParForStatementBlock.java | 10 +--------- 4 files changed, 4 insertions(+), 33 deletions(-) diff --git a/src/main/java/org/apache/sysds/hops/ipa/InterProceduralAnalysis.java b/src/main/java/org/apache/sysds/hops/ipa/InterProceduralAnalysis.java index 2480f0d10c..d7a3fc7f8c 100644 --- a/src/main/java/org/apache/sysds/hops/ipa/InterProceduralAnalysis.java +++ b/src/main/java/org/apache/sysds/hops/ipa/InterProceduralAnalysis.java @@ -77,9 +77,7 @@ import java.util.Set; * recompile once functions, the removal of unnecessary checkpoints, and the * global removal of constant binary operations such as X * ones. */ -public class InterProceduralAnalysis -{ - private static final boolean LDEBUG = false; //internal local debug level +public class InterProceduralAnalysis { private static final Log LOG = LogFactory.getLog(InterProceduralAnalysis.class.getName()); //internal configuration parameters @@ -108,15 +106,6 @@ public class InterProceduralAnalysis //set IPA passes to apply in order private final ArrayList<IPAPass> _passes; - static { - // for internal debugging only - if( LDEBUG ) { - Logger.getLogger("org.apache.sysds.hops.ipa") - .setLevel(Level.TRACE); - } - } - - /** * Creates a handle for performing inter-procedural analysis * for a given DML program and its associated HOP DAGs. This diff --git a/src/main/java/org/apache/sysds/hops/rewrite/ProgramRewriter.java b/src/main/java/org/apache/sysds/hops/rewrite/ProgramRewriter.java index 11105fe7f6..21c70a6850 100644 --- a/src/main/java/org/apache/sysds/hops/rewrite/ProgramRewriter.java +++ b/src/main/java/org/apache/sysds/hops/rewrite/ProgramRewriter.java @@ -48,22 +48,12 @@ import org.apache.sysds.runtime.lineage.LineageCacheConfig; * program. * */ -public class ProgramRewriter -{ - private static final boolean LDEBUG = false; //internal local debug level +public class ProgramRewriter{ private static final boolean CHECK = false; private ArrayList<HopRewriteRule> _dagRuleSet = null; private ArrayList<StatementBlockRewriteRule> _sbRuleSet = null; - static { - // for internal debugging only - if( LDEBUG ) { - Logger.getLogger("org.apache.sysds.hops.rewrite") - .setLevel(Level.DEBUG); - } - } - public ProgramRewriter() { // by default which is used during initial compile // apply all (static and dynamic) rewrites diff --git a/src/main/java/org/apache/sysds/lops/LopProperties.java b/src/main/java/org/apache/sysds/lops/LopProperties.java index 9fce0b6fb0..efa3cd2fe2 100644 --- a/src/main/java/org/apache/sysds/lops/LopProperties.java +++ b/src/main/java/org/apache/sysds/lops/LopProperties.java @@ -29,7 +29,7 @@ public class LopProperties // static variable to assign an unique ID to every lop that is created private static IDSequence UniqueLopID = null; - static{ + static { UniqueLopID = new IDSequence(); } diff --git a/src/main/java/org/apache/sysds/parser/ParForStatementBlock.java b/src/main/java/org/apache/sysds/parser/ParForStatementBlock.java index 130495d03b..5ed91adbd3 100644 --- a/src/main/java/org/apache/sysds/parser/ParForStatementBlock.java +++ b/src/main/java/org/apache/sysds/parser/ParForStatementBlock.java @@ -62,9 +62,7 @@ import org.apache.sysds.runtime.util.UtilFunctions; * for checking/setting optional parfor parameters and running the loop dependency analysis. * */ -public class ParForStatementBlock extends ForStatementBlock -{ - private static final boolean LDEBUG = false; //internal local debug level +public class ParForStatementBlock extends ForStatementBlock { protected static final Log LOG = LogFactory.getLog(ParForStatementBlock.class.getName()); //external parameter names @@ -147,12 +145,6 @@ public class ParForStatementBlock extends ForStatementBlock if( USE_FN_CACHE ) { _fncache = new HashMap<>(); } - - // for internal debugging only - if( LDEBUG ) { - Logger.getLogger("org.apache.sysds.parser.ParForStatementBlock") - .setLevel(Level.TRACE); - } } public ParForStatementBlock() {
