This is an automated email from the ASF dual-hosted git repository.

mboehm7 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/systemds.git


The following commit(s) were added to refs/heads/main by this push:
     new 742eec844b [SYSTEMDS-3765] Reproducible test case for the need of 
time() hoisting
742eec844b is described below

commit 742eec844bd55215ac157d814f6a1680f9db4aae
Author: Matthias Boehm <[email protected]>
AuthorDate: Tue Dec 3 18:54:38 2024 +0100

    [SYSTEMDS-3765] Reproducible test case for the need of time() hoisting
---
 .../functions/rewrite/RewriteHoistingTimeTest.java | 71 ++++++++++++++++++++++
 .../functions/rewrite/RewriteTimeHoisting.dml      | 26 ++++++++
 2 files changed, 97 insertions(+)

diff --git 
a/src/test/java/org/apache/sysds/test/functions/rewrite/RewriteHoistingTimeTest.java
 
b/src/test/java/org/apache/sysds/test/functions/rewrite/RewriteHoistingTimeTest.java
new file mode 100644
index 0000000000..fd7f3bdda4
--- /dev/null
+++ 
b/src/test/java/org/apache/sysds/test/functions/rewrite/RewriteHoistingTimeTest.java
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * 
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.sysds.test.functions.rewrite;
+
+import org.junit.Test;
+import org.apache.sysds.common.Types.ExecMode;
+import org.apache.sysds.common.Types.ExecType;
+import org.apache.sysds.test.AutomatedTestBase;
+import org.apache.sysds.test.TestConfiguration;
+import org.apache.sysds.test.TestUtils;
+
+public class RewriteHoistingTimeTest extends AutomatedTestBase
+{
+       private static final String TEST_NAME1 = "RewriteTimeHoisting";
+       
+       private static final String TEST_DIR = "functions/rewrite/";
+       private static final String TEST_CLASS_DIR = TEST_DIR + 
RewriteHoistingTimeTest.class.getSimpleName() + "/";
+       
+       private static final int rows = 1001;
+       private static final int cols = 1002;
+       
+       @Override
+       public void setUp() {
+               TestUtils.clearAssertionInformation();
+               addTestConfiguration( TEST_NAME1, new 
TestConfiguration(TEST_CLASS_DIR, TEST_NAME1, new String[] {"R"}) );
+       }
+
+       @Test
+       public void testTimeHoisting() {
+               test(TEST_NAME1, ExecType.CP);
+       }
+
+       private void test(String testname, ExecType et)
+       {
+               ExecMode platformOld = setExecMode(et);
+               
+               try
+               {
+                       TestConfiguration config = 
getTestConfiguration(testname);
+                       loadTestConfiguration(config);
+                       
+                       String HOME = SCRIPT_DIR + TEST_DIR;
+                       fullDMLScriptName = HOME + testname + ".dml";
+                       programArgs = new String[] { "-explain", "-args",
+                               String.valueOf(rows), String.valueOf(cols) };
+                       
+                       //FIXME need to hoist time() out of expression similar 
to function calls
+                       runTest(true, false, null, -1); 
+               }
+               finally {
+                       resetExecMode(platformOld);
+               }
+       }
+}
diff --git a/src/test/scripts/functions/rewrite/RewriteTimeHoisting.dml 
b/src/test/scripts/functions/rewrite/RewriteTimeHoisting.dml
new file mode 100644
index 0000000000..b4a4457212
--- /dev/null
+++ b/src/test/scripts/functions/rewrite/RewriteTimeHoisting.dml
@@ -0,0 +1,26 @@
+#-------------------------------------------------------------
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+#-------------------------------------------------------------
+
+t1 = time();
+X = rand(rows=$1, cols=$2);
+
+print("time = "+(time()-t1)/1e9+"s"+" "+sum(X));
+

Reply via email to