This is an automated email from the ASF dual-hosted git repository. baunsgaard pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/systemds.git
commit e868917d76f7f169a5cda8d1db66ea39a2839018 Author: Sebastian Baunsgaard <baunsga...@apache.org> AuthorDate: Fri May 2 11:37:33 2025 +0200 [MINOR] Docker Guide Update --- docker/README.md | 24 ++++++++++++------------ docker/build.sh | 6 +++--- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/docker/README.md b/docker/README.md index db7fd75194..d530061019 100644 --- a/docker/README.md +++ b/docker/README.md @@ -31,22 +31,22 @@ To Build the docker image simply run the build script. ./docker/build.sh ``` -Afterwards you should have a local image with the id `systemds/sysds:latest`. +Afterwards you should have a local image with the id `apache/systemds:latest`. To execute any given DML script follow the step Run. ## Run Running SystemDS in a docker container is as simple as constructing any DML script. -Then download the docker image `systemds/sysds:latest` or build your own. +Then download the docker image `apache/systemds:latest` or build your own. ```bash -docker pull systemds/sysds:latest +docker pull apache/systemds:latest ``` Verify that the docker image correctly works simply by running it. ```bash -docker run --rm systemds/sysds:latest +docker run --rm apache/systemds:latest ``` It should respond with something like: @@ -65,7 +65,7 @@ You can mount any such folder and execute systemds by changing the first part of ```bash docker run \ -v $(pwd)/docker/mountFolder:/input \ - --rm systemds/sysds:latest + --rm apache/systemds:latest ``` Default behavior is to run the script located at /input/main.dml. @@ -74,7 +74,7 @@ To run any other script use: ```bash docker run \ -v $(pwd)/folder/to/share:/any/path/in/docker/instance \ - --rm systemds/sysds:latest \ + --rm apache/systemds:latest \ systemds /any/path/to/a/script.dml ``` @@ -83,7 +83,7 @@ docker run \ To run a federated worker in a docker container simply use: ```bash -docker run -p 8000:8000 --rm systemds/sysds:latest systemds WORKER 8000 +docker run -p 8000:8000 --rm apache/systemds:latest systemds WORKER 8000 ``` This port forwards the worker to port 8000 on the host and starts a worker in the instance on port 8000. @@ -95,7 +95,7 @@ To add a folder containing the data needed in the worker do the following: docker run \ -p 8000:8000 \ -v $(pwd)/data/folder/path/locally:/data/folder/path/in/container \ - --rm systemds/sysds:latest systemds WORKER 8000 + --rm apache/systemds:latest systemds WORKER 8000 ``` ### Docker run python script @@ -103,7 +103,7 @@ docker run \ To run a python script the `pythonsysds` image is used. ```bash -docker run --rm systemds/pythonsysds:latest +docker run --rm apache/systemds:python-nightly ``` User provided scripts have to be mounted into the image. @@ -111,7 +111,7 @@ User provided scripts have to be mounted into the image. ```bash docker run \ -v $(pwd)/data/folder/path/locally:/data/folder/path/in/container \ - --rm systemds/pythonsystds:latest \ + --rm apache/systemds:latest \ python3 path/to/script/to/execute.py ``` @@ -128,7 +128,7 @@ To build this image simply run the same command as above. Because the github action pulls the image from docker hub the image has to be pushed to docker hub to produce any change in the behavior of the testing. ```bash -docker push systemds/testingsysds:latest +docker push apache/systemds:testing-latest ``` For each of the tests that require R, this image is simply used, because it skips the installation of the R packages, since they are installed in this image. @@ -138,6 +138,6 @@ Test your testing image locally by running the following command: ```bash docker run \ -v $(pwd):/github/workspace \ - systemds/testingsysds:latest \ + apache/systemds:testing-latest \ org.apache.sysds.test.component.** ``` diff --git a/docker/build.sh b/docker/build.sh index 30eb9af9b5..02e45675f1 100755 --- a/docker/build.sh +++ b/docker/build.sh @@ -1,4 +1,4 @@ -#/bin/bash +#!/usr/bin/env bash #------------------------------------------------------------- # # Licensed to the Apache Software Foundation (ASF) under one @@ -23,13 +23,13 @@ # Build the docker containers # The first build is for running systemds through docker. -docker image build -f docker/sysds.Dockerfile -t apache/systemds:nightly . +docker image build -f docker/sysds.Dockerfile -t apache/systemds:latest . # The second build is for testing systemds. This image installs the R dependencies needed to run the tests. docker image build -f docker/testsysds.Dockerfile -t apache/systemds:testing-latest . # The third build is python docker for systemds. -docker image build -f docker/pythonsysds.Dockerfile -t apache/systemds:python-nightly . +# docker image build -f docker/pythonsysds.Dockerfile -t apache/systemds:python-nightly . # You might want to prune the docker system afterwards using # docker system prune