(systemds) branch main updated: [MINOR] Fix missing result correctness check in selected tests

[mboehm7]

This is an automated email from the ASF dual-hosted git repository.

mboehm7 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/systemds.git


The following commit(s) were added to refs/heads/main by this push:
     new b090e49d91 [MINOR] Fix missing result correctness check in selected 
tests
b090e49d91 is described below

commit b090e49d9152eb7fef303af140175b7c3911c991
Author: Matthias Boehm <mboe...@gmail.com>
AuthorDate: Fri Nov 28 17:20:20 2025 +0100

    [MINOR] Fix missing result correctness check in selected tests
    
    A while ago the internals of TestUtils.compareCellValue changed to not
    raise assertion failures directly. This change caused some tests to
    miss a proper result comparison check.
---
 .../sysds/test/component/codegen/CPlanVectorPrimitivesTest.java     | 6 +++---
 .../apache/sysds/test/component/compress/CompressedVectorTest.java  | 3 ++-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git 
a/src/test/java/org/apache/sysds/test/component/codegen/CPlanVectorPrimitivesTest.java
 
b/src/test/java/org/apache/sysds/test/component/codegen/CPlanVectorPrimitivesTest.java
index bae22b1c38..d8268cf06a 100644
--- 
a/src/test/java/org/apache/sysds/test/component/codegen/CPlanVectorPrimitivesTest.java
+++ 
b/src/test/java/org/apache/sysds/test/component/codegen/CPlanVectorPrimitivesTest.java
@@ -22,6 +22,7 @@ package org.apache.sysds.test.component.codegen;
 import java.lang.reflect.Method;
 
 import org.apache.sysds.runtime.data.SparseRowVector;
+import org.junit.Assert;
 import org.junit.Test;
 import org.apache.sysds.common.Types.OpOp2;
 import org.apache.sysds.hops.codegen.cplan.CNodeBinary.BinType;
@@ -44,7 +45,7 @@ public class CPlanVectorPrimitivesTest extends 
AutomatedTestBase
        private static final int n = 132;
        private static final double sparsity1 = 0.9;
        private static final double sparsity2 = 0.09;
-       private static final double eps = Math.pow(10, -10);
+       private static final double eps = 1e-10;
        
        private enum InputType {
                SCALAR,
@@ -998,7 +999,6 @@ public class CPlanVectorPrimitivesTest extends 
AutomatedTestBase
                testVectorUnarySparsePrimitive(UnaryType.VECT_SIGN, 
InputType.VECTOR_SPARSE);
        }
 
-       @SuppressWarnings("incomplete-switch")
        private static void testVectorAggPrimitive(UnaryType aggtype, InputType 
type1)
        {
                try {
@@ -1031,7 +1031,7 @@ public class CPlanVectorPrimitivesTest extends 
AutomatedTestBase
                                }
                                
                                //compare results
-                               TestUtils.compareCellValue(ret1, ret2, eps, 
false);
+                               Assert.assertEquals(ret1, ret2, eps);
                        }
                } 
                catch( Exception ex ) {
diff --git 
a/src/test/java/org/apache/sysds/test/component/compress/CompressedVectorTest.java
 
b/src/test/java/org/apache/sysds/test/component/compress/CompressedVectorTest.java
index 5d91ddb273..8aea861d9e 100644
--- 
a/src/test/java/org/apache/sysds/test/component/compress/CompressedVectorTest.java
+++ 
b/src/test/java/org/apache/sysds/test/component/compress/CompressedVectorTest.java
@@ -38,6 +38,7 @@ import 
org.apache.sysds.test.component.compress.TestConstants.OverLapping;
 import org.apache.sysds.test.component.compress.TestConstants.SparsityType;
 import org.apache.sysds.test.component.compress.TestConstants.ValueRange;
 import org.apache.sysds.test.component.compress.TestConstants.ValueType;
+import org.junit.Assert;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
@@ -117,7 +118,7 @@ public class CompressedVectorTest extends 
CompressedTestBase {
                        double ret2 = cmb.sortOperations().pickValue(0.95);
 
                        if(_cs.lossy)
-                               TestUtils.compareCellValue(ret1, ret2, 
lossyTolerance, false);
+                               Assert.assertEquals(ret1, ret2, lossyTolerance);
                        else
                                assertTrue(bufferedToString, 
TestUtils.compareScalarBits(ret1, ret2, 0));