Repository: incubator-systemml Updated Branches: refs/heads/master c9b6f02e7 -> 873229f30
[SYSTEMML-762] Adding debugging information to identify unknown dimensions for ConvolutionOp This will help the DML user reason about why local MR jobs were created. Project: http://git-wip-us.apache.org/repos/asf/incubator-systemml/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-systemml/commit/873229f3 Tree: http://git-wip-us.apache.org/repos/asf/incubator-systemml/tree/873229f3 Diff: http://git-wip-us.apache.org/repos/asf/incubator-systemml/diff/873229f3 Branch: refs/heads/master Commit: 873229f30527c8bfe6dc9399f53fd9f6dbb5b10e Parents: c9b6f02 Author: Niketan Pansare <[email protected]> Authored: Wed Jun 22 18:52:43 2016 -0700 Committer: Niketan Pansare <[email protected]> Committed: Wed Jun 22 18:52:43 2016 -0700 ---------------------------------------------------------------------- .../java/org/apache/sysml/hops/ConvolutionOp.java | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/873229f3/src/main/java/org/apache/sysml/hops/ConvolutionOp.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/sysml/hops/ConvolutionOp.java b/src/main/java/org/apache/sysml/hops/ConvolutionOp.java index 28b1f36..751da51 100644 --- a/src/main/java/org/apache/sysml/hops/ConvolutionOp.java +++ b/src/main/java/org/apache/sysml/hops/ConvolutionOp.java @@ -361,6 +361,14 @@ public class ConvolutionOp extends Hop implements MultiThreadedHop throw new RuntimeException("Unsupported op:" + op.name()); } + if(LOG.isDebugEnabled() && (ret[0] <= 0 || ret[1] <= 0)) { + LOG.debug("Unknown dimensions for ConvolutionOp in inferOutputCharacteristics:" + op.name() + " " + ret[0] + " " + ret[1] + + " img_dim=[" + params.N + " " + params.C + " " + params.H + " " + params.W + "]" + + " filter_dim=[" + params.K + " " + params.C + " " + params.H + " " + params.W + "]" + + " output_feature_map=[" + params.P + " " + params.Q + "] stride=[" + params.stride_h + " " + params.stride_w + "]" + + " pad=[" + params.pad_h + " " + params.pad_w + "]"); + } + return ret; } @@ -540,6 +548,14 @@ public class ConvolutionOp extends Hop implements MultiThreadedHop default: throw new RuntimeException("The sizes are not refreshed for " + op.name()); } + + if(LOG.isDebugEnabled() && (_dim1 <= 0 || _dim2 <= 0)) { + LOG.debug("Unknown dimensions for ConvolutionOp in refreshSizeInformation:" + op.name() + " " + _dim1 + " " + _dim2 + + " img_dim=[" + params.N + " " + params.C + " " + params.H + " " + params.W + "]" + + " filter_dim=[" + params.K + " " + params.C + " " + params.H + " " + params.W + "]" + + " output_feature_map=[" + params.P + " " + params.Q + "] stride=[" + params.stride_h + " " + params.stride_w + "]" + + " pad=[" + params.pad_h + " " + params.pad_w + "]"); + } } public static long extractValue(Hop hop) {
