Repository: systemml Updated Branches: refs/heads/master e52c8713d -> 8fb74b158
[MINOR] Fix case of externalFunction classname message Use constant for 'classname' in externalFunction error message, since the previous 'className' in the error message does not work. Closes #634. Project: http://git-wip-us.apache.org/repos/asf/systemml/repo Commit: http://git-wip-us.apache.org/repos/asf/systemml/commit/8fb74b15 Tree: http://git-wip-us.apache.org/repos/asf/systemml/tree/8fb74b15 Diff: http://git-wip-us.apache.org/repos/asf/systemml/diff/8fb74b15 Branch: refs/heads/master Commit: 8fb74b158f1011c16538b1fcb4ca905090db1e8a Parents: e52c871 Author: Deron Eriksson <[email protected]> Authored: Thu Aug 24 10:59:33 2017 -0700 Committer: Deron Eriksson <[email protected]> Committed: Thu Aug 24 10:59:33 2017 -0700 ---------------------------------------------------------------------- .../org/apache/sysml/parser/dml/DmlSyntacticValidator.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/systemml/blob/8fb74b15/src/main/java/org/apache/sysml/parser/dml/DmlSyntacticValidator.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/sysml/parser/dml/DmlSyntacticValidator.java b/src/main/java/org/apache/sysml/parser/dml/DmlSyntacticValidator.java index 2ae6fd8..bcedc97 100644 --- a/src/main/java/org/apache/sysml/parser/dml/DmlSyntacticValidator.java +++ b/src/main/java/org/apache/sysml/parser/dml/DmlSyntacticValidator.java @@ -852,13 +852,14 @@ public class DmlSyntacticValidator extends CommonSyntacticValidator implements D return; } otherParams.put(paramName, val); - if(paramName.equals("classname")) { + if (paramName.equals(ExternalFunctionStatement.CLASS_NAME)) { atleastOneClassName = true; } } functionStmt.setOtherParams(otherParams); - if(!atleastOneClassName) { - notifyErrorListeners("the parameter \'className\' needs to be passed for externalFunction", ctx.start); + if (!atleastOneClassName) { + notifyErrorListeners("The \'" + ExternalFunctionStatement.CLASS_NAME + + "\' argument needs to be passed to the externalFunction 'implemented in' clause.", ctx.start); return; }
