Repository: systemml Updated Branches: refs/heads/master 8dad38d23 -> a83c25019
[SYSTEMML-2178,2183] Revert ANTLR version upgrade (back to 4.5.3) This patch reverts the ANTLR version update from 4.5.3 to 4.7.1 for Spark 2.3 because it lost backwards compatibility with Spark 2.1 and 2.2. Compiling our source with an older version works with warnings on Spark 2.3 and without issues on Spark 2.1 and 2.2, while a newer version would produce runtime errors on Spark 2.1 and 2.2. In our SystemML 1.1 release notes we should deprecate the support for Spark 2.1 and 2.2 and in SystemML 1.2 make the switch to the newer ANTLR version. Project: http://git-wip-us.apache.org/repos/asf/systemml/repo Commit: http://git-wip-us.apache.org/repos/asf/systemml/commit/880cc66b Tree: http://git-wip-us.apache.org/repos/asf/systemml/tree/880cc66b Diff: http://git-wip-us.apache.org/repos/asf/systemml/diff/880cc66b Branch: refs/heads/master Commit: 880cc66bc318cbb4b6547702762a07cf3486ba1e Parents: 8dad38d Author: Matthias Boehm <[email protected]> Authored: Sun Mar 11 18:24:31 2018 -0700 Committer: Matthias Boehm <[email protected]> Committed: Sun Mar 11 19:29:04 2018 -0700 ---------------------------------------------------------------------- pom.xml | 2 +- src/main/java/org/apache/sysml/parser/dml/DMLParserWrapper.java | 1 - .../java/org/apache/sysml/parser/pydml/PyDMLParserWrapper.java | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/systemml/blob/880cc66b/pom.xml ---------------------------------------------------------------------- diff --git a/pom.xml b/pom.xml index 75625a9..5313be8 100644 --- a/pom.xml +++ b/pom.xml @@ -62,7 +62,7 @@ <properties> <hadoop.version>2.6.0</hadoop.version> - <antlr.version>4.7.1</antlr.version> + <antlr.version>4.5.3</antlr.version> <spark.version>2.1.0</spark.version> <scala.version>2.11.8</scala.version> <scala.binary.version>2.11</scala.binary.version> http://git-wip-us.apache.org/repos/asf/systemml/blob/880cc66b/src/main/java/org/apache/sysml/parser/dml/DMLParserWrapper.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/sysml/parser/dml/DMLParserWrapper.java b/src/main/java/org/apache/sysml/parser/dml/DMLParserWrapper.java index 0b9747a..8714968 100644 --- a/src/main/java/org/apache/sysml/parser/dml/DMLParserWrapper.java +++ b/src/main/java/org/apache/sysml/parser/dml/DMLParserWrapper.java @@ -71,7 +71,6 @@ import org.apache.sysml.parser.dml.DmlParser.StatementContext; * If in future we intend to make it multi-threaded, look at cleanUpState method and resolve the dependency accordingly. * */ -@SuppressWarnings("deprecation") public class DMLParserWrapper extends ParserWrapper { private static final Log LOG = LogFactory.getLog(DMLScript.class.getName()); http://git-wip-us.apache.org/repos/asf/systemml/blob/880cc66b/src/main/java/org/apache/sysml/parser/pydml/PyDMLParserWrapper.java ---------------------------------------------------------------------- diff --git a/src/main/java/org/apache/sysml/parser/pydml/PyDMLParserWrapper.java b/src/main/java/org/apache/sysml/parser/pydml/PyDMLParserWrapper.java index 2c931a8..8a81b46 100644 --- a/src/main/java/org/apache/sysml/parser/pydml/PyDMLParserWrapper.java +++ b/src/main/java/org/apache/sysml/parser/pydml/PyDMLParserWrapper.java @@ -54,7 +54,6 @@ import org.apache.sysml.parser.pydml.PydmlParser.StatementContext; * Note: ExpressionInfo and StatementInfo are simply wrapper objects and are reused in both DML and PyDML parsers. * */ -@SuppressWarnings("deprecation") public class PyDMLParserWrapper extends ParserWrapper { private static final Log LOG = LogFactory.getLog(DMLScript.class.getName());
