Repository: systemml Updated Branches: refs/heads/master bf72cc475 -> b85aea348
[HOTFIX] Fix test tolerance for compressed sumsq unary aggregates The test for compressed sumsq unary aggregates shows a large scale of 3e9 for full aggregates, which rendered the tight absolute tolerance of 1e-9 to aggressive for certain environments such as the new Travis CI build. We now use a smaller absolute tolerance for these cases. Project: http://git-wip-us.apache.org/repos/asf/systemml/repo Commit: http://git-wip-us.apache.org/repos/asf/systemml/commit/040c1009 Tree: http://git-wip-us.apache.org/repos/asf/systemml/tree/040c1009 Diff: http://git-wip-us.apache.org/repos/asf/systemml/diff/040c1009 Branch: refs/heads/master Commit: 040c1009aefca98ae666020b16ac4f3a2cba1369 Parents: bf72cc4 Author: Matthias Boehm <[email protected]> Authored: Tue May 22 19:41:50 2018 -0700 Committer: Matthias Boehm <[email protected]> Committed: Tue May 22 19:41:50 2018 -0700 ---------------------------------------------------------------------- .../integration/functions/compress/ParUnaryAggregateTest.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/systemml/blob/040c1009/src/test/java/org/apache/sysml/test/integration/functions/compress/ParUnaryAggregateTest.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/sysml/test/integration/functions/compress/ParUnaryAggregateTest.java b/src/test/java/org/apache/sysml/test/integration/functions/compress/ParUnaryAggregateTest.java index f346bc9..fefe8b6 100644 --- a/src/test/java/org/apache/sysml/test/integration/functions/compress/ParUnaryAggregateTest.java +++ b/src/test/java/org/apache/sysml/test/integration/functions/compress/ParUnaryAggregateTest.java @@ -1079,7 +1079,7 @@ public class ParUnaryAggregateTest extends AutomatedTestBase if( compress ) cmb.compress(); - //matrix-vector uncompressed + //matrix-vector uncompressed MatrixBlock ret1 = (MatrixBlock)mb.aggregateUnaryOperations(auop, new MatrixBlock(), 1000, 1000, null, true); //matrix-vector compressed @@ -1092,7 +1092,9 @@ public class ParUnaryAggregateTest extends AutomatedTestBase || aggtype == AggType.ROWMINS || aggtype == AggType.ROWMINS)?rows:1; int dim2 = (aggtype == AggType.COLSUMS || aggtype == AggType.COLSUMSSQ || aggtype == AggType.COLMAXS || aggtype == AggType.COLMINS)?cols1:1; - TestUtils.compareMatrices(d1, d2, dim1, dim2, 0.000000001); + //since sumsq has a large value domain, we use a smaller absolute eps + double eps = (aggtype==AggType.SUMSQ || aggtype==AggType.COLSUMSSQ) ? 1e-7 : 1e-9; + TestUtils.compareMatrices(d1, d2, dim1, dim2, eps); } catch(Exception ex) { throw new RuntimeException(ex);
