TAJO-1370: TUtils.checkEquals() is not consistent with description in javadoc.
Closes #397 Signed-off-by: Hyunsik Choi <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/tajo/repo Commit: http://git-wip-us.apache.org/repos/asf/tajo/commit/6ba51c3c Tree: http://git-wip-us.apache.org/repos/asf/tajo/tree/6ba51c3c Diff: http://git-wip-us.apache.org/repos/asf/tajo/diff/6ba51c3c Branch: refs/heads/index_support Commit: 6ba51c3cd3f20ce9c7e945d78b0cd2c4eaefc362 Parents: f1aeb73 Author: navis.ryu <[email protected]> Authored: Thu Mar 5 14:23:09 2015 +0900 Committer: Hyunsik Choi <[email protected]> Committed: Sun Mar 8 14:54:11 2015 -0700 ---------------------------------------------------------------------- CHANGES | 3 +++ tajo-common/src/main/java/org/apache/tajo/util/TUtil.java | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tajo/blob/6ba51c3c/CHANGES ---------------------------------------------------------------------- diff --git a/CHANGES b/CHANGES index 003ae1a..9d986f1 100644 --- a/CHANGES +++ b/CHANGES @@ -16,6 +16,9 @@ Release 0.11.0 - unreleased BUG FIXES + TAJO-1370 TUtils.checkEquals() is not consistent with description + in javadoc. (Contributed by navis, Committed by hyunsik) + TAJO-1362: Resolve findbug warnings on Tajo Core Module. (jihun) TAJO-1366: The timestamp type conversion occasionally leads to wrong http://git-wip-us.apache.org/repos/asf/tajo/blob/6ba51c3c/tajo-common/src/main/java/org/apache/tajo/util/TUtil.java ---------------------------------------------------------------------- diff --git a/tajo-common/src/main/java/org/apache/tajo/util/TUtil.java b/tajo-common/src/main/java/org/apache/tajo/util/TUtil.java index 30ad04f..75f3e2a 100644 --- a/tajo-common/src/main/java/org/apache/tajo/util/TUtil.java +++ b/tajo-common/src/main/java/org/apache/tajo/util/TUtil.java @@ -50,10 +50,10 @@ public class TUtil { * @return true if they are equal or all null */ public static boolean checkEquals(Collection<?> s1, Collection<?> s2) { - if (s1 == null || s2 == null) { - return false; - } else if (s1 == null && s2 == null) { + if (s1 == null && s2 == null) { return true; + } else if (s1 == null || s2 == null) { + return false; } else { if (s1.size() == 0 && s2.size() == 0) { return true;
