TAMAYA-53 Excluded check for unused private methods (UPM_UNCALLED_PRIVATE_METHOD) from analysis. Currently FindBugs 3.0.0 is not able to detect their usage via method references.
Project: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/1d1f2954 Tree: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/1d1f2954 Diff: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/1d1f2954 Branch: refs/heads/master Commit: 1d1f29541e2b3b80d0b0dd8a413007885b085f23 Parents: 1ca82f8 Author: Oliver B. Fischer <[email protected]> Authored: Mon Feb 9 08:17:08 2015 +0100 Committer: Oliver B. Fischer <[email protected]> Committed: Mon Feb 9 08:17:08 2015 +0100 ---------------------------------------------------------------------- .../resources/findbugs/findbugs-exclude.xml | 79 ++------------------ 1 file changed, 7 insertions(+), 72 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/1d1f2954/buildconfigurations/src/main/resources/findbugs/findbugs-exclude.xml ---------------------------------------------------------------------- diff --git a/buildconfigurations/src/main/resources/findbugs/findbugs-exclude.xml b/buildconfigurations/src/main/resources/findbugs/findbugs-exclude.xml index 7b89819..aba0172 100644 --- a/buildconfigurations/src/main/resources/findbugs/findbugs-exclude.xml +++ b/buildconfigurations/src/main/resources/findbugs/findbugs-exclude.xml @@ -18,68 +18,26 @@ specific language governing permissions and limitations under the License. --> <FindBugsFilter> - - <Match> - <Class name="org.apache.tamaya.core.internal.DefaultConfigurationContext$1"/> - </Match> - <Match> - <Class name="org.apache.tamaya.core.internal.DefaultConfigurationContext$2"/> - </Match> - <Match> - <Class name="org.apache.tamaya.core.internal.DefaultConfigurationContext$3"/> - </Match> - <Match> - <Class name="org.apache.tamaya.core.internal.DefaultConfigurationContext$4"/> - </Match> <Match> <!-- Note: The current version of FindBugs (version 3.0.0) is not able to detect the usage of this method via a method reference. Oliver B. Fischer, 17.01.2015 --> - <Class name="org.apache.tamaya.core.internal.DefaultConfigurationContext"/> - <Method name="comparePropertySources" - params="org.apache.tamaya.spi.PropertySource,org.apache.tamaya.spi.PropertySource" - returns="int"/> <Bug pattern="UPM_UNCALLED_PRIVATE_METHOD"/> </Match> + <Match> - <!-- Note: - The current version of FindBugs (version 3.0.0) is not able to detect - the usage of this method via a method reference. - Oliver B. Fischer, 17.01.2015 - --> - <Class name=" org.apache.tamaya.builder.ProgrammaticConfigurationContext"/> - <Method name="comparePropertyFilters" - params="org.apache.tamaya.spi.PropertyFilter,org.apache.tamaya.spi.PropertyFilter" - returns="int"/> - <Bug pattern="UPM_UNCALLED_PRIVATE_METHOD"/> + <Class name="org.apache.tamaya.core.internal.DefaultConfigurationContext$1"/> </Match> <Match> - <!-- Note: - The current version of FindBugs (version 3.0.0) is not able to detect - the usage of this method via a method reference. - Oliver B. Fischer, 17.01.2015 - --> - <Class name=" org.apache.tamaya.builder.ProgrammaticConfigurationContext"/> - <Method name="comparePropertySources" - params="org.apache.tamaya.spi.PropertySource,org.apache.tamaya.spi.PropertySource" - returns="int"/> - <Bug pattern="UPM_UNCALLED_PRIVATE_METHOD"/> + <Class name="org.apache.tamaya.core.internal.DefaultConfigurationContext$2"/> </Match> - <Match> - <!-- Note: - The current version of FindBugs (version 3.0.0) is not able to detect - the usage of this method via a method reference. - Oliver B. Fischer, 17.01.2015 - --> - - <Class name="org.apache.tamaya.core.internal.DefaultConfigurationContext"/> - <Method name="comparePropertyFilters" - params="org.apache.tamaya.spi.PropertyFilter,org.apache.tamaya.spi.PropertyFilter" - returns="int"/> - <Bug pattern="UPM_UNCALLED_PRIVATE_METHOD"/> + <Class name="org.apache.tamaya.core.internal.DefaultConfigurationContext$3"/> + </Match> + <Match> + <Class name="org.apache.tamaya.core.internal.DefaultConfigurationContext$4"/> </Match> <Match> @@ -124,20 +82,6 @@ under the License. * findBugs does not detect usage via method references * should be removed after see TODO ProgrammaticConfigurationContext:131 --> - <Match> - <Class name="org.apache.tamaya.builder.ProgrammaticConfigurationContext" /> - <Method name="comparePropertySources" - params="org.apache.tamaya.spi.PropertySource,org.apache.tamaya.spi.PropertySource" - returns="int" /> - <Bug pattern="UPM_UNCALLED_PRIVATE_METHOD" /> - </Match> - <Match> - <Class name="org.apache.tamaya.builder.ProgrammaticConfigurationContext" /> - <Method name="comparePropertyFilters" - params="org.apache.tamaya.spi.PropertyFilter,org.apache.tamaya.spi.PropertyFilter" - returns="int" /> - <Bug pattern="UPM_UNCALLED_PRIVATE_METHOD" /> - </Match> <!-- Issues to review --> @@ -175,14 +119,5 @@ under the License. <Match> <Class name="org.apache.tamaya.inject.PropertyChangeSetBuilder" /> </Match> - <!--<Match>--> - <!--<Class name="org.apache.tamaya.inject.internal.ConfiguredType" />--> - <!--</Match>--> - <!--<Match>--> - <!--<Class name="org.apache.tamaya.inject.internal.ConfigTemplateInvocationHandler" />--> - <!--</Match>--> - <!--<Match>--> - <!--<Class name="org.apache.tamaya.inject.DynamicValue" />--> - <!--</Match>--> </FindBugsFilter>
