Repository: incubator-tamaya-extensions Updated Branches: refs/heads/master 74e6cda80 -> b32e1c5b8
[TAMAYA-227] Method enabledMonitoring(...) does now work as expected. Project: http://git-wip-us.apache.org/repos/asf/incubator-tamaya-extensions/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-tamaya-extensions/commit/b32e1c5b Tree: http://git-wip-us.apache.org/repos/asf/incubator-tamaya-extensions/tree/b32e1c5b Diff: http://git-wip-us.apache.org/repos/asf/incubator-tamaya-extensions/diff/b32e1c5b Branch: refs/heads/master Commit: b32e1c5b856e446ea8a2e1ead9466a0244ce4f54 Parents: 74e6cda Author: Oliver B. Fischer <[email protected]> Authored: Sun Jan 29 21:39:55 2017 +0100 Committer: Oliver B. Fischer <[email protected]> Committed: Sun Jan 29 21:39:55 2017 +0100 ---------------------------------------------------------------------- .../internal/DefaultConfigChangeObserver.java | 2 +- .../DefaultConfigChangeObserverTest.java | 50 ++++++++++++++++++++ 2 files changed, 51 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-tamaya-extensions/blob/b32e1c5b/modules/events/src/main/java/org/apache/tamaya/events/internal/DefaultConfigChangeObserver.java ---------------------------------------------------------------------- diff --git a/modules/events/src/main/java/org/apache/tamaya/events/internal/DefaultConfigChangeObserver.java b/modules/events/src/main/java/org/apache/tamaya/events/internal/DefaultConfigChangeObserver.java index 34bf5eb..6d8c694 100644 --- a/modules/events/src/main/java/org/apache/tamaya/events/internal/DefaultConfigChangeObserver.java +++ b/modules/events/src/main/java/org/apache/tamaya/events/internal/DefaultConfigChangeObserver.java @@ -87,7 +87,7 @@ public class DefaultConfigChangeObserver { } public void enableMonitoring(boolean enable){ - this.running = true; + this.running = enable; } /** http://git-wip-us.apache.org/repos/asf/incubator-tamaya-extensions/blob/b32e1c5b/modules/events/src/test/java/org/apache/tamaya/events/internal/DefaultConfigChangeObserverTest.java ---------------------------------------------------------------------- diff --git a/modules/events/src/test/java/org/apache/tamaya/events/internal/DefaultConfigChangeObserverTest.java b/modules/events/src/test/java/org/apache/tamaya/events/internal/DefaultConfigChangeObserverTest.java new file mode 100644 index 0000000..6d62bd1 --- /dev/null +++ b/modules/events/src/test/java/org/apache/tamaya/events/internal/DefaultConfigChangeObserverTest.java @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.tamaya.events.internal; + +import org.junit.Test; + +import static org.assertj.core.api.Assertions.assertThat; + +public class DefaultConfigChangeObserverTest { + private DefaultConfigChangeObserver sut = new DefaultConfigChangeObserver(); + + @Test + public void enableMonitoringCalledWithTrueEnablesMonitoring() { + assertThat(sut.isMonitoring()).isFalse(); + + sut.enableMonitoring(true); + + assertThat(sut.isMonitoring()).isTrue(); + } + + @Test + public void enableMonitoringCalledWithFalseDisablesMonitoring() { + assertThat(sut.isMonitoring()).isFalse(); + + sut.enableMonitoring(true); + + assertThat(sut.isMonitoring()).isTrue(); + + sut.enableMonitoring(false); + + assertThat(sut.isMonitoring()).isFalse(); + } + +} \ No newline at end of file
