Add equality tests
Project: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/45f5bb90 Tree: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/45f5bb90 Diff: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/45f5bb90 Branch: refs/heads/master Commit: 45f5bb90bb48e1dc083e6e67138c140112f1dcab Parents: 6119aff Author: Aaron Coburn <[email protected]> Authored: Tue Mar 6 11:23:30 2018 -0500 Committer: Aaron Coburn <[email protected]> Committed: Tue Mar 6 11:23:30 2018 -0500 ---------------------------------------------------------------------- .../internal/converters/BigDecimalConverterTest.java | 11 ++++++++++- .../internal/converters/BigIntegerConverterTest.java | 9 +++++++++ .../core/internal/converters/BooleanConverterTest.java | 8 ++++++++ .../core/internal/converters/ByteConverterTest.java | 9 +++++++++ .../core/internal/converters/CharConverterTest.java | 9 +++++++++ .../core/internal/converters/ClassConverterTest.java | 9 +++++++++ .../core/internal/converters/CurrencyConverterTest.java | 9 +++++++++ .../core/internal/converters/DoubleConverterTest.java | 8 ++++++++ .../core/internal/converters/DurationConverterTest.java | 10 +++++++++- .../core/internal/converters/FileConverterTest.java | 9 +++++++++ .../core/internal/converters/FloatConverterTest.java | 7 +++++++ .../core/internal/converters/InstantConverterTest.java | 4 +++- .../core/internal/converters/LocalDateConverterTest.java | 4 +++- .../internal/converters/LocalDateTimeConverterTest.java | 4 +++- .../core/internal/converters/LocalTimeConverterTest.java | 4 +++- .../core/internal/converters/LongConverterTest.java | 11 ++++++++++- .../core/internal/converters/NumberConverterTest.java | 11 ++++++++++- .../internal/converters/OffsetDateTimeConverterTest.java | 4 +++- .../internal/converters/OffsetTimeConverterTest.java | 2 ++ .../core/internal/converters/OptionalConverterTest.java | 9 +++++++++ .../core/internal/converters/PathConverterTest.java | 2 ++ .../core/internal/converters/ShortConverterTest.java | 11 ++++++++++- .../core/internal/converters/SupplierConverterTest.java | 9 +++++++++ .../core/internal/converters/URIConverterTest.java | 11 +++++++++-- .../core/internal/converters/URLConverterTest.java | 9 +++++++++ 25 files changed, 181 insertions(+), 12 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/BigDecimalConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/BigDecimalConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/BigDecimalConverterTest.java index 06c7685..6d81946 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/BigDecimalConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/BigDecimalConverterTest.java @@ -135,4 +135,13 @@ public class BigDecimalConverterTest { assertThat(value).isNull(); verify(context).addSupportedFormats(BigDecimalConverter.class, "<bigDecimal> -> new BigDecimal(String)"); } -} \ No newline at end of file + + @Test + public void testEquality() throws Exception { + BigDecimalConverter converter = new BigDecimalConverter(); + + assertThat(converter).isEqualTo(new BigDecimalConverter()); + assertThat(converter).isNotEqualTo(new BigIntegerConverter()); + assertThat(converter).isNotEqualTo(null); + } +} http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/BigIntegerConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/BigIntegerConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/BigIntegerConverterTest.java index b283a0c..78c5807 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/BigIntegerConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/BigIntegerConverterTest.java @@ -157,4 +157,13 @@ public class BigIntegerConverterTest { assertThat(instance.hashCode()).isEqualTo(BigIntegerConverter.class.hashCode()); } + @Test + public void testEquality() { + BigIntegerConverter converter = new BigIntegerConverter(); + + assertThat(converter).isEqualTo(new BigIntegerConverter()); + assertThat(converter).isNotEqualTo(new BooleanConverter()); + assertThat(converter).isNotEqualTo(null); + } + } http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/BooleanConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/BooleanConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/BooleanConverterTest.java index 2bf8d57..946c0fd 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/BooleanConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/BooleanConverterTest.java @@ -147,4 +147,12 @@ public class BooleanConverterTest { assertThat(instance.hashCode()).isEqualTo(BooleanConverter.class.hashCode()); } + @Test + public void testEquality() { + BooleanConverter converter = new BooleanConverter(); + + assertThat(converter).isEqualTo(new BooleanConverter()); + assertThat(converter).isNotEqualTo(new ByteConverter()); + assertThat(converter).isNotEqualTo(null); + } } http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/ByteConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/ByteConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/ByteConverterTest.java index 9c2562b..15ca345 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/ByteConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/ByteConverterTest.java @@ -110,4 +110,13 @@ public class ByteConverterTest { ByteConverter instance = new ByteConverter(); assertThat(instance.hashCode()).isEqualTo(ByteConverter.class.hashCode()); } + + @Test + public void testEquality() { + ByteConverter converter = new ByteConverter(); + + assertThat(converter).isEqualTo(new ByteConverter()); + assertThat(converter).isNotEqualTo(new CharConverter()); + assertThat(converter).isNotEqualTo(null); + } } http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/CharConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/CharConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/CharConverterTest.java index 067ef4f..8c8de46 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/CharConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/CharConverterTest.java @@ -164,4 +164,13 @@ public class CharConverterTest { CharConverter instance = new CharConverter(); assertThat(instance.hashCode()).isEqualTo(CharConverter.class.hashCode()); } + + @Test + public void testEquality() { + CharConverter converter = new CharConverter(); + + assertThat(converter).isEqualTo(new CharConverter()); + assertThat(converter).isNotEqualTo(new ClassConverter()); + assertThat(converter).isNotEqualTo(null); + } } http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/ClassConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/ClassConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/ClassConverterTest.java index 78d9675..f6ca999 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/ClassConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/ClassConverterTest.java @@ -79,4 +79,13 @@ public class ClassConverterTest { ClassConverter instance = new ClassConverter(); assertThat(instance.hashCode()).isEqualTo(ClassConverter.class.hashCode()); } + + @Test + public void testEquality() { + ClassConverter converter = new ClassConverter(); + + assertThat(converter).isEqualTo(new ClassConverter()); + assertThat(converter).isNotEqualTo(new CurrencyConverter()); + assertThat(converter).isNotEqualTo(null); + } } http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/CurrencyConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/CurrencyConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/CurrencyConverterTest.java index 13b3060..155cf0c 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/CurrencyConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/CurrencyConverterTest.java @@ -202,4 +202,13 @@ public class CurrencyConverterTest { CurrencyConverter instance = new CurrencyConverter(); assertThat(instance.hashCode()).isEqualTo(CurrencyConverter.class.hashCode()); } + + @Test + public void testEquality() { + CurrencyConverter converter = new CurrencyConverter(); + + assertThat(converter).isEqualTo(new CurrencyConverter()); + assertThat(converter).isNotEqualTo(new DoubleConverter()); + assertThat(converter).isNotEqualTo(null); + } } http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/DoubleConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/DoubleConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/DoubleConverterTest.java index f7da834..d3a88fd 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/DoubleConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/DoubleConverterTest.java @@ -198,4 +198,12 @@ public class DoubleConverterTest { assertThat(instance.hashCode()).isEqualTo(DoubleConverter.class.hashCode()); } + @Test + public void testEquality() { + DoubleConverter converter = new DoubleConverter(); + + assertThat(converter).isEqualTo(new DoubleConverter()); + assertThat(converter).isNotEqualTo(new DurationConverter()); + assertThat(converter).isNotEqualTo(null); + } } http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/DurationConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/DurationConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/DurationConverterTest.java index e78c940..5aa9939 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/DurationConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/DurationConverterTest.java @@ -92,4 +92,12 @@ public class DurationConverterTest { assertThat(instance.hashCode()).isEqualTo(DurationConverter.class.hashCode()); } -} \ No newline at end of file + @Test + public void testEquality() { + DurationConverter converter = new DurationConverter(); + + assertThat(converter).isEqualTo(new DurationConverter()); + assertThat(converter).isNotEqualTo(new FileConverter()); + assertThat(converter).isNotEqualTo(null); + } +} http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/FileConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/FileConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/FileConverterTest.java index 3342bb9..5282b84 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/FileConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/FileConverterTest.java @@ -55,4 +55,13 @@ public class FileConverterTest { FileConverter instance = new FileConverter(); assertThat(instance.hashCode()).isEqualTo(FileConverter.class.hashCode()); } + + @Test + public void testEquality() { + FileConverter converter = new FileConverter(); + + assertThat(converter).isEqualTo(new FileConverter()); + assertThat(converter).isNotEqualTo(new FloatConverter()); + assertThat(converter).isNotEqualTo(null); + } } http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/FloatConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/FloatConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/FloatConverterTest.java index e9b3b7c..c5c4866 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/FloatConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/FloatConverterTest.java @@ -198,5 +198,12 @@ public class FloatConverterTest { assertThat(instance.hashCode()).isEqualTo(FloatConverter.class.hashCode()); } + @Test + public void testEquality() { + FloatConverter converter = new FloatConverter(); + assertThat(converter).isEqualTo(new FloatConverter()); + assertThat(converter).isNotEqualTo(new InstantConverter()); + assertThat(converter).isNotEqualTo(null); + } } http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/InstantConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/InstantConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/InstantConverterTest.java index c812dfd..40257c3 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/InstantConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/InstantConverterTest.java @@ -53,6 +53,8 @@ public class InstantConverterTest { InstantConverter conv2 = new InstantConverter(); assertThat(conv2).isEqualTo(conv1); assertThat(conv2.hashCode()).isEqualTo(conv1.hashCode()); + assertThat(conv1).isNotEqualTo(new IntegerConverter()); + assertThat(conv1).isNotEqualTo(null); } @Test @@ -70,4 +72,4 @@ public class InstantConverterTest { assertThat(instance.hashCode()).isEqualTo(InstantConverter.class.hashCode()); } -} \ No newline at end of file +} http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LocalDateConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LocalDateConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LocalDateConverterTest.java index e082de2..341254b 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LocalDateConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LocalDateConverterTest.java @@ -53,6 +53,8 @@ public class LocalDateConverterTest { LocalDateConverter conv2 = new LocalDateConverter(); assertThat(conv2).isEqualTo(conv1); assertThat(conv2.hashCode()).isEqualTo(conv1.hashCode()); + assertThat(conv2).isNotEqualTo(null); + assertThat(conv2).isNotEqualTo(new LocalDateTimeConverter()); } @Test @@ -69,4 +71,4 @@ public class LocalDateConverterTest { LocalDateConverter instance = new LocalDateConverter(); assertThat(instance.hashCode()).isEqualTo(LocalDateConverter.class.hashCode()); } -} \ No newline at end of file +} http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LocalDateTimeConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LocalDateTimeConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LocalDateTimeConverterTest.java index 09d82da..b92d6fa 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LocalDateTimeConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LocalDateTimeConverterTest.java @@ -53,6 +53,8 @@ public class LocalDateTimeConverterTest { LocalDateTimeConverter conv2 = new LocalDateTimeConverter(); assertThat(conv2).isEqualTo(conv1); assertThat(conv2.hashCode()).isEqualTo(conv1.hashCode()); + assertThat(conv2).isNotEqualTo(new LocalTimeConverter()); + assertThat(conv2).isNotEqualTo(null); } @Test @@ -69,4 +71,4 @@ public class LocalDateTimeConverterTest { LocalDateTimeConverter instance = new LocalDateTimeConverter(); assertThat(instance.hashCode()).isEqualTo(LocalDateTimeConverter.class.hashCode()); } -} \ No newline at end of file +} http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LocalTimeConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LocalTimeConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LocalTimeConverterTest.java index 4045ad5..6b8707d 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LocalTimeConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LocalTimeConverterTest.java @@ -53,6 +53,8 @@ public class LocalTimeConverterTest { LocalTimeConverter conv2 = new LocalTimeConverter(); assertThat(conv2).isEqualTo(conv1); assertThat(conv2.hashCode()).isEqualTo(conv1.hashCode()); + assertThat(conv2).isNotEqualTo(new LongConverter()); + assertThat(conv2).isNotEqualTo(null); } @Test @@ -69,4 +71,4 @@ public class LocalTimeConverterTest { LocalTimeConverter instance = new LocalTimeConverter(); assertThat(instance.hashCode()).isEqualTo(LocalTimeConverter.class.hashCode()); } -} \ No newline at end of file +} http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LongConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LongConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LongConverterTest.java index 401d2e5..06e62a7 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LongConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/LongConverterTest.java @@ -134,4 +134,13 @@ public class LongConverterTest { LongConverter instance = new LongConverter(); assertThat(instance.hashCode()).isEqualTo(LongConverter.class.hashCode()); } -} \ No newline at end of file + + @Test + public void testEquality() { + LongConverter converter = new LongConverter(); + + assertThat(converter).isEqualTo(new LongConverter()); + assertThat(converter).isNotEqualTo(new NumberConverter()); + assertThat(converter).isNotEqualTo(null); + } +} http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/NumberConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/NumberConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/NumberConverterTest.java index 2376bb3..76bc778 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/NumberConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/NumberConverterTest.java @@ -167,4 +167,13 @@ public class NumberConverterTest { NumberConverter instance = new NumberConverter(); assertThat(instance.hashCode()).isEqualTo(NumberConverter.class.hashCode()); } -} \ No newline at end of file + + @Test + public void testEquality() { + NumberConverter converter = new NumberConverter(); + + assertThat(converter).isEqualTo(new NumberConverter()); + assertThat(converter).isNotEqualTo(new OffsetDateTimeConverter()); + assertThat(converter).isNotEqualTo(null); + } +} http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/OffsetDateTimeConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/OffsetDateTimeConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/OffsetDateTimeConverterTest.java index f702070..3daf49f 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/OffsetDateTimeConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/OffsetDateTimeConverterTest.java @@ -54,6 +54,8 @@ public class OffsetDateTimeConverterTest { OffsetDateTimeConverter conv2 = new OffsetDateTimeConverter(); assertThat(conv2).isEqualTo(conv1); assertThat(conv2.hashCode()).isEqualTo(conv1.hashCode()); + assertThat(conv2).isNotEqualTo(new OffsetTimeConverter()); + assertThat(conv2).isNotEqualTo(null); } @Test @@ -70,4 +72,4 @@ public class OffsetDateTimeConverterTest { OffsetDateTimeConverter instance = new OffsetDateTimeConverter(); assertThat(instance.hashCode()).isEqualTo(OffsetDateTimeConverter.class.hashCode()); } -} \ No newline at end of file +} http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/OffsetTimeConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/OffsetTimeConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/OffsetTimeConverterTest.java index 49edb07..dc21c85 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/OffsetTimeConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/OffsetTimeConverterTest.java @@ -52,6 +52,8 @@ public class OffsetTimeConverterTest { OffsetTimeConverter conv1 = new OffsetTimeConverter(); OffsetTimeConverter conv2 = new OffsetTimeConverter(); assertThat(conv2).isEqualTo(conv1); + assertThat(conv2).isNotEqualTo(new OptionalConverter()); + assertThat(conv2).isNotEqualTo(null); assertThat(conv2.hashCode()).isEqualTo(conv1.hashCode()); } http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/OptionalConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/OptionalConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/OptionalConverterTest.java index 584e9d2..e928a94 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/OptionalConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/OptionalConverterTest.java @@ -74,4 +74,13 @@ public class OptionalConverterTest { OptionalConverter instance = new OptionalConverter(); assertThat(instance.hashCode()).isEqualTo(OptionalConverter.class.hashCode()); } + + @Test + public void testEquality() { + OptionalConverter converter = new OptionalConverter(); + + assertThat(converter).isEqualTo(new OptionalConverter()); + assertThat(converter).isNotEqualTo(new PathConverter()); + assertThat(converter).isNotEqualTo(null); + } } http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/PathConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/PathConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/PathConverterTest.java index 97b24b9..4e2f153 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/PathConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/PathConverterTest.java @@ -69,6 +69,8 @@ public class PathConverterTest { PathConverter conv1 = new PathConverter(); PathConverter conv2 = new PathConverter(); assertThat(conv2).isEqualTo(conv1); + assertThat(conv2).isNotEqualTo(new ShortConverter()); + assertThat(conv2).isNotEqualTo(null); assertThat(conv2.hashCode()).isEqualTo(conv1.hashCode()); } http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/ShortConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/ShortConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/ShortConverterTest.java index 9c69750..9f9ba72 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/ShortConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/ShortConverterTest.java @@ -135,4 +135,13 @@ public class ShortConverterTest { ShortConverter instance = new ShortConverter(); assertThat(instance.hashCode()).isEqualTo(ShortConverter.class.hashCode()); } -} \ No newline at end of file + + @Test + public void testEquality() { + ShortConverter converter = new ShortConverter(); + + assertThat(converter).isEqualTo(new ShortConverter()); + assertThat(converter).isNotEqualTo(new SupplierConverter()); + assertThat(converter).isNotEqualTo(null); + } +} http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/SupplierConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/SupplierConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/SupplierConverterTest.java index 5660c1d..3d52333 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/SupplierConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/SupplierConverterTest.java @@ -73,6 +73,15 @@ public class SupplierConverterTest { assertThat(instance.hashCode()).isEqualTo(SupplierConverter.class.hashCode()); } + @Test + public void testEquality() { + SupplierConverter converter = new SupplierConverter(); + + assertThat(converter).isEqualTo(new SupplierConverter()); + assertThat(converter).isNotEqualTo(new URIConverter()); + assertThat(converter).isNotEqualTo(null); + } + private class MyConverter<T extends InetAddress> implements PropertyConverter<InetAddress> { @Override http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/URIConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/URIConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/URIConverterTest.java index ac727cf..61f84fa 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/URIConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/URIConverterTest.java @@ -86,6 +86,13 @@ public class URIConverterTest { URIConverter instance = new URIConverter(); assertThat(instance.hashCode()).isEqualTo(URIConverter.class.hashCode()); } - - + + @Test + public void testEquality() { + URIConverter converter = new URIConverter(); + + assertThat(converter).isEqualTo(new URIConverter()); + assertThat(converter).isNotEqualTo(new URLConverter()); + assertThat(converter).isNotEqualTo(null); + } } http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/45f5bb90/code/core/src/test/java/org/apache/tamaya/core/internal/converters/URLConverterTest.java ---------------------------------------------------------------------- diff --git a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/URLConverterTest.java b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/URLConverterTest.java index b4dbb1e..f2def82 100644 --- a/code/core/src/test/java/org/apache/tamaya/core/internal/converters/URLConverterTest.java +++ b/code/core/src/test/java/org/apache/tamaya/core/internal/converters/URLConverterTest.java @@ -87,4 +87,13 @@ public class URLConverterTest { URLConverter instance = new URLConverter(); assertThat(instance.hashCode()).isEqualTo(URLConverter.class.hashCode()); } + + @Test + public void testEquality() { + URLConverter converter = new URLConverter(); + + assertThat(converter).isEqualTo(new URLConverter()); + assertThat(converter).isNotEqualTo(new BigDecimalConverter()); + assertThat(converter).isNotEqualTo(null); + } }
