Repository: incubator-tamaya Updated Branches: refs/heads/master c97b5e713 -> 19f165725
Removal of the no longer needed jqassistant directory. Project: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/19f16572 Tree: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/19f16572 Diff: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/19f16572 Branch: refs/heads/master Commit: 19f165725117007f8b359ca9d4bd49a0fe64a9ad Parents: c97b5e7 Author: Oliver B. Fischer <[email protected]> Authored: Sat May 5 02:08:50 2018 +0200 Committer: Oliver B. Fischer <[email protected]> Committed: Sat May 5 02:08:50 2018 +0200 ---------------------------------------------------------------------- jqassistant/default.xml | 63 ---------------- jqassistant/module-concepts.xml | 55 -------------- jqassistant/readme.md | 8 -- jqassistant/serviceloader-rules.xml | 125 ------------------------------- 4 files changed, 251 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/19f16572/jqassistant/default.xml ---------------------------------------------------------------------- diff --git a/jqassistant/default.xml b/jqassistant/default.xml deleted file mode 100644 index c35ec68..0000000 --- a/jqassistant/default.xml +++ /dev/null @@ -1,63 +0,0 @@ -<!-- -Licensed to the Apache Software Foundation (ASF) under one -or more contributor license agreements. See the NOTICE file -distributed with this work for additional information -regarding copyright ownership. The ASF licenses this file -to you under the Apache License, Version 2.0 (the -"License"); you may not use this file except in compliance -with the License. You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, -software distributed under the License is distributed on an -"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -KIND, either express or implied. See the License for the -specific language governing permissions and limitations -under the License. ---> -<jqa:jqassistant-rules xmlns:jqa="http://www.buschmais.com/jqassistant/core/analysis/rules/schema/v1.0";> - - <constraint id="naming:namingOfPropertyConverters"> - <requiresConcept refId="java:AnonymousInnerType" /> - <description>Class name of implementations of PropertyConverter must end with 'Converter'</description> - <cypher><![CDATA[ - MATCH - (t:Type)-[:IMPLEMENTS*]->(i:Type) - - WHERE - i.fqn='org.apache.tamaya.spi.PropertyConverter' - AND NOT t:Anonymous:Inner - AND NOT t.name =~ '.*Converter' - - RETURN - t.fqn - ]]></cypher> - </constraint> - - <constraint id="naming:namingOfPropertyFilters"> - <requiresConcept refId="java:AnonymousInnerType"/> - <description>Class name of implementations of PropertyFilter must end with 'Filter'</description> - <cypher><![CDATA[ - MATCH - (t:Type)-[:IMPLEMENTS*]->(i:Type) - - WHERE - i.fqn='org.apache.tamaya.spi.PropertyFilter' - AND NOT t:Anonymous:Inner - AND NOT t.name =~ '.*Filter' - - RETURN - t.fqn - ]]></cypher> - </constraint> - - <group id="default"> - <includeConstraint refId="naming:namingOfPropertyConverters"/> - <includeConstraint refId="naming:namingOfPropertyFilters"/> - <includeConstraint refId="serviceLoader:correctServiceLoaderNaming"/> - <includeConstraint refId="serviceLoader:ServiceImplementationsMustBeListedInServiceConfigurations"/> - <includeConstraint refId="serviceLoader:serviceConfigurationsMustNotBeEmpty"/> - <includeConstraint refId="serviceLoader:serviceConfigurationsMustNotContainNonExistingClasses"/> - </group> -</jqa:jqassistant-rules> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/19f16572/jqassistant/module-concepts.xml ---------------------------------------------------------------------- diff --git a/jqassistant/module-concepts.xml b/jqassistant/module-concepts.xml deleted file mode 100644 index 29369ed..0000000 --- a/jqassistant/module-concepts.xml +++ /dev/null @@ -1,55 +0,0 @@ -<!-- -Licensed to the Apache Software Foundation (ASF) under one -or more contributor license agreements. See the NOTICE file -distributed with this work for additional information -regarding copyright ownership. The ASF licenses this file -to you under the Apache License, Version 2.0 (the -"License"); you may not use this file except in compliance -with the License. You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, -software distributed under the License is distributed on an -"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -KIND, either express or implied. See the License for the -specific language governing permissions and limitations -under the License. ---> -<jqa:jqassistant-rules xmlns:jqa="http://www.buschmais.com/jqassistant/core/analysis/rules/schema/v1.0";> - - <concept id="module:SPI"> - <description>Labels all .spi packages as "SPI".</description> - <cypher><![CDATA[ - MATCH - (package:Package) - - WHERE - package.name = "spi" - - SET - package:SPI - - RETURN - package - ]]></cypher> - </concept> - - <concept id="module:API"> - <description>Labels all .api packages as "API".</description> - <cypher><![CDATA[ - MATCH - (package:Package) - - WHERE - package.name = "api" - - SET - package:API - - RETURN - package - ]]></cypher> - </concept> - -</jqa:jqassistant-rules> \ No newline at end of file http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/19f16572/jqassistant/readme.md ---------------------------------------------------------------------- diff --git a/jqassistant/readme.md b/jqassistant/readme.md deleted file mode 100644 index 5e67ec5..0000000 --- a/jqassistant/readme.md +++ /dev/null @@ -1,8 +0,0 @@ -# Rules for jQAssistant - -This directory contains the rules for -jQAssitant. A tool used by Tamaya to -ensure some contraints on our project. - -You can learn more on jQAssitant at http://jqassistant.org/ - http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/19f16572/jqassistant/serviceloader-rules.xml ---------------------------------------------------------------------- diff --git a/jqassistant/serviceloader-rules.xml b/jqassistant/serviceloader-rules.xml deleted file mode 100644 index c8dd907..0000000 --- a/jqassistant/serviceloader-rules.xml +++ /dev/null @@ -1,125 +0,0 @@ -<!-- -Licensed to the Apache Software Foundation (ASF) under one -or more contributor license agreements. See the NOTICE file -distributed with this work for additional information -regarding copyright ownership. The ASF licenses this file -to you under the Apache License, Version 2.0 (the -"License"); you may not use this file except in compliance -with the License. You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, -software distributed under the License is distributed on an -"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -KIND, either express or implied. See the License for the -specific language governing permissions and limitations -under the License. ---> -<jqa:jqassistant-rules xmlns:jqa="http://www.buschmais.com/jqassistant/core/analysis/rules/schema/v1.0";> - - <concept id="serviceLoader:SPI"> - <description>Labels all .spi packages as "SPI".</description> - <cypher><![CDATA[ - MATCH - (package:Package)-->(type:Type:Java) - - WHERE - package.name = "spi" - - SET - type:SPI - - RETURN - type - ]]></cypher> - </concept> - - <constraint id="serviceLoader:correctServiceLoaderNaming"> - <requiresConcept refId="serviceLoader:SPI"/> - <description>A service provider must be contained in a service provider configuration file with the full qualified binary name of the service's type.</description> - <cypher><![CDATA[ - MATCH - (sl:ServiceLoader)-[:CONTAINS]->(impl:Type)-[:IMPLEMENTS]->(spi:SPI) - - WHERE - NOT split(sl.fileName, '/')[-1] = spi.fqn - - RETURN - impl.fqn AS impl, spi.fqn as spi, sl.fileName AS spiConfig - ]]></cypher> - </constraint> - - <constraint id="serviceLoader:ServiceImplementationsMustBeListedInServiceConfigurations" - severity="info"> - <requiresConcept refId="java:AnonymousInnerType"/> - <requiresConcept refId="serviceLoader:SPI"/> - <description>All property converter implementations must be declared in a service loader file.</description> - <cypher><![CDATA[ - MATCH - (impl)-[:IMPLEMENTS*]->(spi:SPI) - - WHERE - NOT (:ServiceLoader)-[:CONTAINS]->(impl) - AND NOT impl:Anonymous:Inner - AND (impl.abstract=false OR impl.abstract IS NULL) - - // Ignore SPI implementations without a default constructor - // We assume that the developer of this class had to implement for some reason - // this interface but not intended it to be used as service provider - AND NOT (impl)-[:DECLARES]->(:Constructor)-[:HAS]->(:Parameter) - - // Do not pay attention to test utilities. We rely on the name of the class - AND NOT (impl.name =~ 'Test.*' OR impl.name =~ '.*\\$Test.*' - OR impl.name =~'.*Test\\$.*') - - AND NOT impl.fqn IN [// All classes of the builder MUST not use the SPI mechanism - 'org.apache.tamaya.builder.internal.ProgrammaticConfigurationContext' - // See TAMAYA-77 and TAMAYA-78, Oliver B. Fischer, 2015-04-25 - // 'org.apache.tamaya.core.internal.DefaultConfigurationContextBuilder' - ] - - RETURN - impl.fqn AS undeclaredService - ]]></cypher> - </constraint> - - <constraint id="serviceLoader:serviceConfigurationsMustNotBeEmpty"> - <requiresConcept refId="serviceLoader:SPI"/> - <description>Empty service configurations must not be provided.</description> - <cypher><![CDATA[ - MATCH - (sc:ServiceLoader) - - WHERE - NOT (sc)-[:CONTAINS]->() - - RETURN - sc.fileName AS emptyServiceConfiguration - ]]></cypher> - </constraint> - - <constraint id="serviceLoader:serviceConfigurationsMustNotContainNonExistingClasses"> - <requiresConcept refId="serviceLoader:SPI"/> - <description>Service configurations must contain only existing classes.</description> - <cypher><![CDATA[ - MATCH - (sl:ServiceLoader)-[:CONTAINS]->(entry) - - WHERE - NOT entry:Class - - // Have to exclude these files as jQAssistant cannot handle inner classes in - // service configurations in version 1.0.0. - // I reported this problem already to the project - // Oliver B. Fischer, 15.5.5 - AND NOT sl.fileName IN ['/META-INF/services/org.apache.tamaya.spisupport.DefaultServiceContextTest$MultiImplsInterface', - '/META-INF/services/org.apache.tamaya.spisupport.DefaultServiceContextTest$InvalidPriorityInterface', - '/META-INF/services/org.apache.tamaya.spisupport.DefaultServiceContextTest$InvalidPriorityInterface'] - - RETURN - sl.fileName AS serviceConfiguration, entry.name AS class - ]]></cypher> - </constraint> - -</jqa:jqassistant-rules>
