ottlinger commented on issue #20: TAMAYA-379: enforce checkstyle validation URL: https://github.com/apache/incubator-tamaya-sandbox/pull/20#issuecomment-457867363 @acoburn not sure about the checkstyle rules concerning the casing - following the "official" Javadoc guide I'd also uppercase the private final constants .... not sure, but if the rule is there, we could easily comply with it. https://www.oracle.com/technetwork/java/codeconventions-135099.html > Constants > The names of variables declared class constants and of ANSI constants should be all uppercase with words separated by underscores ("_"). (ANSI constants should be avoided, for ease of debugging.) > static final int MIN_WIDTH = 4; > static final int MAX_WIDTH = 999; > static final int GET_THE_CPU = 1;
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
