This is an automated email from the ASF dual-hosted git repository. acoburn pushed a commit to branch TAMAYA-387 in repository https://gitbox.apache.org/repos/asf/incubator-tamaya.git
commit 91617dc44037885fac64c8edfc52a591d9d29c34 Author: Aaron Coburn <[email protected]> AuthorDate: Tue Apr 23 16:50:35 2019 -0400 TAMAYA-387 Upgrade checkstyle plugin This upgrades the checkstyle plugin to 8.19 The exclusion code in the maven configuration are no longer relevant, and the style.xml file itself needed some minor modifications that go along with the upgrade to the 8.x series --- buildconfigurations/src/main/resources/checkstyle/style.xml | 5 +---- pom.xml | 8 +------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/buildconfigurations/src/main/resources/checkstyle/style.xml b/buildconfigurations/src/main/resources/checkstyle/style.xml index ec99292..bf9f310 100644 --- a/buildconfigurations/src/main/resources/checkstyle/style.xml +++ b/buildconfigurations/src/main/resources/checkstyle/style.xml @@ -26,8 +26,6 @@ under the License. <property name="file" value="${checkstyle.suppressions.file}"/> </module> - <module name="SuppressionCommentFilter"/> - <!-- Checks for Size Violations. --> <!-- See http://checkstyle.sf.net/config_sizes.html --> <module name="FileLength"> @@ -41,8 +39,7 @@ under the License. <module name="TreeWalker"> - <!-- needed for the SuppressionCommentFilter --> - <module name="FileContentsHolder"/> + <module name="SuppressionCommentFilter"/> <!-- Checks for Javadoc comments. --> <!-- See http://checkstyle.sf.net/config_javadoc.html --> diff --git a/pom.xml b/pom.xml index 4b25dd1..3bc8ee1 100644 --- a/pom.xml +++ b/pom.xml @@ -402,13 +402,7 @@ <dependency> <groupId>com.puppycrawl.tools</groupId> <artifactId>checkstyle</artifactId> - <version>7.8</version> - <exclusions><!-- MCHECKSTYLE-156 --> - <exclusion> - <groupId>com.sun</groupId> - <artifactId>tools</artifactId> - </exclusion> - </exclusions> + <version>8.19</version> </dependency> </dependencies> </plugin>
