acoburn commented on issue #49: TAMAYA-277: LHF: use try-with-resources with BufferedReader URL: https://github.com/apache/incubator-tamaya/pull/49#issuecomment-488420011 I suppose the question is whether Sonar non-compliance should be allowed to fail a build or not. I personally find Sonar to be very useful, but I typically put it in a `after_success` clause like this: ``` script: mvn clean install after_success: mvn sonar:sonar -Dsonar.organization=apache -Dsonar.projectKey=apache_incubator-tamaya ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
