svn commit: r502590 - in /tapestry/tapestry4/trunk: src/site/xdoc/components/form/imagesubmit.xml tapestry-framework/src/java/org/apache/tapestry/form/ImageSubmit.java tapestry-framework/src/test/org/apache/tapestry/form/TestImageSubmit.java

[andyhot]

Author: andyhot
Date: Fri Feb  2 04:47:07 2007
New Revision: 502590

URL: http://svn.apache.org/viewvc?view=rev&rev=502590
Log:
TAPESTRY-1231: (X)HTML compliance

Modified:
    tapestry/tapestry4/trunk/src/site/xdoc/components/form/imagesubmit.xml
    
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/ImageSubmit.java
    
tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/TestImageSubmit.java

Modified: tapestry/tapestry4/trunk/src/site/xdoc/components/form/imagesubmit.xml
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/src/site/xdoc/components/form/imagesubmit.xml?view=diff&rev=502590&r1=502589&r2=502590
==============================================================================
--- tapestry/tapestry4/trunk/src/site/xdoc/components/form/imagesubmit.xml 
(original)
+++ tapestry/tapestry4/trunk/src/site/xdoc/components/form/imagesubmit.xml Fri 
Feb  2 04:47:07 2007
@@ -284,7 +284,7 @@
 
                 <p>
                     Reserved parameters:
-                    <em>type, src, border</em>
+                    <em>type, src</em>
                 </p>
 
                 <span class="warn">

Modified: 
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/ImageSubmit.java
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/ImageSubmit.java?view=diff&rev=502590&r1=502589&r2=502590
==============================================================================
--- 
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/ImageSubmit.java
 (original)
+++ 
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/ImageSubmit.java
 Fri Feb  2 04:47:07 2007
@@ -65,12 +65,7 @@
         writer.attribute("name", getName());
         
         if (disabled)
-            writer.attribute("disabled", "disabled");
-        
-        // NN4 places a border unless you tell it otherwise.
-        // IE ignores the border attribute and never shows a border.
-        
-        writer.attribute("border", 0);
+            writer.attribute("disabled", "disabled");        
         
         writer.attribute("src", imageURL);
 

Modified: 
tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/TestImageSubmit.java
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/TestImageSubmit.java?view=diff&rev=502590&r1=502589&r2=502590
==============================================================================
--- 
tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/TestImageSubmit.java
 (original)
+++ 
tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/TestImageSubmit.java
 Fri Feb  2 04:47:07 2007
@@ -99,8 +99,7 @@
         
         writer.beginEmpty("input");
         writer.attribute("type", "image");
-        writer.attribute("name", "fred");
-        writer.attribute("border", 0);
+        writer.attribute("name", "fred");        
         writer.attribute("src", "image-url");
         
         writer.attribute("id", "fred");
@@ -150,8 +149,7 @@
         writer.beginEmpty("input");
         writer.attribute("type", "image");
         writer.attribute("name", "fred");
-        writer.attribute("disabled", "disabled");
-        writer.attribute("border", 0);
+        writer.attribute("disabled", "disabled");        
         writer.attribute("src", "disabled-image-url");
         
         writer.attribute("id", "fred");
@@ -197,8 +195,7 @@
         writer.beginEmpty("input");
         writer.attribute("type", "image");
         writer.attribute("name", "fred");
-        writer.attribute("disabled", "disabled");
-        writer.attribute("border", 0);
+        writer.attribute("disabled", "disabled");        
         writer.attribute("src", "image-url");
         
         writer.attribute("id", "fred");
@@ -243,8 +240,7 @@
         
         writer.beginEmpty("input");
         writer.attribute("type", "image");
-        writer.attribute("name", "barney$0");
-        writer.attribute("border", 0);
+        writer.attribute("name", "barney$0");        
         writer.attribute("src", "image-url");
         writer.closeTag();