svn commit: r511077 - in /tapestry/tapestry5/tapestry-core/trunk/src/main/java/org/apache/tapestry/internal/services: ComponentClassLocatorImpl.java ComponentClassResolverImpl.java

[hlship]

Author: hlship
Date: Fri Feb 23 12:21:20 2007
New Revision: 511077

URL: http://svn.apache.org/viewvc?view=rev&rev=511077
Log:
Add some extra synchronizations to remove the continuous integration server 
instability.

Modified:
    
tapestry/tapestry5/tapestry-core/trunk/src/main/java/org/apache/tapestry/internal/services/ComponentClassLocatorImpl.java
    
tapestry/tapestry5/tapestry-core/trunk/src/main/java/org/apache/tapestry/internal/services/ComponentClassResolverImpl.java

Modified: 
tapestry/tapestry5/tapestry-core/trunk/src/main/java/org/apache/tapestry/internal/services/ComponentClassLocatorImpl.java
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry5/tapestry-core/trunk/src/main/java/org/apache/tapestry/internal/services/ComponentClassLocatorImpl.java?view=diff&rev=511077&r1=511076&r2=511077
==============================================================================
--- 
tapestry/tapestry5/tapestry-core/trunk/src/main/java/org/apache/tapestry/internal/services/ComponentClassLocatorImpl.java
 (original)
+++ 
tapestry/tapestry5/tapestry-core/trunk/src/main/java/org/apache/tapestry/internal/services/ComponentClassLocatorImpl.java
 Fri Feb 23 12:21:20 2007
@@ -51,7 +51,12 @@
         }
     }
 
-    public Collection<String> locateComponentClassNames(String packageName)
+    /**
+     * Synchronization should not be necessary, but perhaps the underlying 
ClassLoader's are
+     * sensitive to threading. This is just a shot in the dark to address our 
continuous integration
+     * instability.
+     */
+    public synchronized Collection<String> locateComponentClassNames(String 
packageName)
     {
         String packagePath = packageName.replace('.', '/') + "/";
 

Modified: 
tapestry/tapestry5/tapestry-core/trunk/src/main/java/org/apache/tapestry/internal/services/ComponentClassResolverImpl.java
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry5/tapestry-core/trunk/src/main/java/org/apache/tapestry/internal/services/ComponentClassResolverImpl.java?view=diff&rev=511077&r1=511076&r2=511077
==============================================================================
--- 
tapestry/tapestry5/tapestry-core/trunk/src/main/java/org/apache/tapestry/internal/services/ComponentClassResolverImpl.java
 (original)
+++ 
tapestry/tapestry5/tapestry-core/trunk/src/main/java/org/apache/tapestry/internal/services/ComponentClassResolverImpl.java
 Fri Feb 23 12:21:20 2007
@@ -222,7 +222,8 @@
      *            mapping from logical name to class name
      * @return the located class name or null
      */
-    private String locate(String logicalName, Map<String, String> 
logicalNameToClassName)
+    private synchronized String locate(String logicalName,
+            Map<String, String> logicalNameToClassName)
     {
         rebuild();
 
@@ -237,7 +238,7 @@
         return result;
     }
 
-    public String resolvePageClassNameToPageName(String pageClassName)
+    public synchronized String resolvePageClassNameToPageName(String 
pageClassName)
     {
         rebuild();