[
https://issues.apache.org/jira/browse/TAP5-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Köberl updated TAP5-713:
----------------------------------
Attachment: SaxTemplateParserImpl.java
First, good news: the parser works (my 3rd attachment)! We have it running in
our test environment.
Bad news: there are still some integration tests failing, namely:
-
extend_without_base_template(org.apache.tapestry5.integration.IntegrationTests)
Time elapsed: 0.328 sec <<< FAILURE!
java.lang.AssertionError: Page did not contain 'Component
org.apache.tapestry5.integration.app1.pages.InvalidTemplateExtend uses an
extension template, but does not have a parent component.'.
-
component_extends_parent_template(org.apache.tapestry5.integration.IntegrationTests)
Time elapsed: 0.344 sec <<< FAILURE!
com.thoughtworks.selenium.SeleniumException: ERROR: Element title not found
Then, I get 2 errors in the TemplateParserImplTest when running the whole suite
from command line. When I run just single test from Eclipse (for debugging) it
works fine:
- parse_failure(org.apache.tapestry5.internal.services.TemplateParserImplTest)
Time elapsed: 0 sec <<< FAILURE!
java.lang.AssertionError: expected:<2> but was:<4>
- just_HTML(org.apache.tapestry5.internal.services.TemplateParserImplTest)
Time elapsed: 0 sec <<< FAILURE!
java.lang.AssertionError: expected:<6> but was:<8>
And finally I my template parser reports on the following test line number 3
(which I think should be correct):
{ "content_within_body_element.tml", "Content inside a Tapestry body element is
not allowed", 2 },
I will investigate on this the next days - help welcome.
> Change template parser to not use STAX, as it is not (yet) compatible with
> Google App Engine
> --------------------------------------------------------------------------------------------
>
> Key: TAP5-713
> URL: https://issues.apache.org/jira/browse/TAP5-713
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Attachments: SaxTemplateParserImpl.java, SaxTemplateParserImpl.java,
> SaxTemplateParserImpl.java
>
>
> The StAX APIs are not on the GAE "white list".
> Should be reasonable ot change the code, by using a SAX parser that parses
> the template into a list of tokens, and then iterate down the token list as
> we do today using StAX. End result will be fewer dependencies to boot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
