svn commit: r911921 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5: internal/services/InternalClassTransformationImpl.java services/ClassTransformation.java

[hlship]

Author: hlship
Date: Fri Feb 19 18:53:50 2010
New Revision: 911921

URL: http://svn.apache.org/viewvc?rev=911921&view=rev
Log:
Add createField() to ClassTransformation, replacing addField()

Modified:
    
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/InternalClassTransformationImpl.java
    
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ClassTransformation.java

Modified: 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/InternalClassTransformationImpl.java
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/InternalClassTransformationImpl.java?rev=911921&r1=911920&r2=911921&view=diff
==============================================================================
--- 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/InternalClassTransformationImpl.java
 (original)
+++ 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/InternalClassTransformationImpl.java
 Fri Feb 19 18:53:50 2010
@@ -1692,10 +1692,10 @@
 
     public String addField(int modifiers, String type, String suggestedName)
     {
-        return addTransformField(modifiers, type, suggestedName).getName();
+        return createField(modifiers, type, suggestedName).getName();
     }
 
-    private TransformField addTransformField(int modifiers, String type, 
String suggestedName)
+    public TransformField createField(int modifiers, String type, String 
suggestedName)
     {
         failIfFrozen();
 
@@ -1762,7 +1762,7 @@
         Defense.notNull(type, "type");
         Defense.notNull(provider, "provider");
 
-        TransformField field = addTransformField(Modifier.PRIVATE | 
Modifier.FINAL, type.getName(), suggestedName);
+        TransformField field = createField(Modifier.PRIVATE | Modifier.FINAL, 
type.getName(), suggestedName);
 
         String argName = addConstructorArg(providerType, provider);
 

Modified: 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ClassTransformation.java
URL: 
http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ClassTransformation.java?rev=911921&r1=911920&r2=911921&view=diff
==============================================================================
--- 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ClassTransformation.java
 (original)
+++ 
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ClassTransformation.java
 Fri Feb 19 18:53:50 2010
@@ -284,10 +284,25 @@
      *            the desired name for the field, which may be modified (for 
uniqueness) when
      *            returned
      * @return the (uniqued) name for the field
+     * @deprecated Use {...@link #createField(int, String, String)} instead
      */
     String addField(int modifiers, String type, String suggestedName);
 
     /**
+     * Defines a new declared field for the class. Suggested name may be 
modified to ensure uniqueness.
+     * 
+     * @param modifiers
+     *            modifiers for the field (typically, {...@link 
java.lang.reflect.Modifier#PRIVATE})
+     * @param type
+     *            the type for the field, as a string
+     * @param suggestedName
+     *            the desired name for the field, which may be modified (for 
uniqueness) when
+     *            returned
+     * @return new field instance
+     */
+    TransformField createField(int modifiers, String type, String 
suggestedName);
+
+    /**
      * Defines a new <strong>protected</strong> instance variable whose 
initial value is provided
      * statically, via a
      * constructor parameter. The transformation caches the result, so calling 
this method