ClassTransformation deprecated a bunch of methods, then refers to replacements 
that don't exist
-----------------------------------------------------------------------------------------------

                 Key: TAP5-1138
                 URL: https://issues.apache.org/jira/browse/TAP5-1138
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-core
            Reporter: Pierce Wetter


ClassTransformation both deprecated and REMOVED several methods, like 
extendMethod, addMethod, etc. 

First, while deprecating is fine, removal is a bad habit. Why not just change 
the implementation to use the new approach?

i.e.:

 if this is what extendMethod turns into:

method = 
transformation.getOrCreateMethod(TransformConstants.BEGIN_RENDER_SIGNATURE);
        method.extend(
            tokenField.getName() + " = " + interField
            + ".checkBefore(" + configField + ");"
        );

Then just put that code in extend method. 

Second, there is no new approach! extendMethod suggests using 
TransformMethod.extend, but there is no TransformMethod.extend.

Note: Discovered while attempting to port tapestry-spring-security to 
5.2.0-SNAPSHOT

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to