[jira] Commented: (TAP5-1011) When using @PageActivationContext and providing a no-args activate event handler, the handler may be called too soon

[Alexander Gavrilov (JIRA)]

    [ 
https://issues.apache.org/jira/browse/TAP5-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915351#action_12915351
 ] 

Alexander Gavrilov commented on TAP5-1011:
------------------------------------------

Its seems like the following case still fail

public class BasePage {
    private MyEntity entity;  
     
    protected void setEntity(MyEntity entity) {
         this.entity = entity;
    }
      
    protected void onActivate() {
        if (entity == null) throw new RuntimeException("Entity not found.");    
    } 
}

public class ConcreteClass {

    @PageActivationContext 
    private MyEntity entity; 

    protected void onActivate() { 
        setEntity(entity);
        super.onActivate();
    } 
}

Shold i clone this issue or you can reopet it?

> When using @PageActivationContext and providing a no-args activate event 
> handler, the handler may be called too soon
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1011
>                 URL: https://issues.apache.org/jira/browse/TAP5-1011
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.1.0.5
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.2.1
>
>
> It appears that the onActivate() method is called before the 
> @PageActivationContext logic, which means the following can fail:
> @PageActivationContext
> private MyEntity entity;
> void onActivate()
> {
>   if (entity == null) throw new RuntimeException("Entity not found.");
> }
> The RuntimeException is thrown even when a valid Entity is in the page 
> activation context.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.