[
https://issues.apache.org/jira/browse/TAP5-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971836#action_12971836
]
Josh Canfield commented on TAP5-1373:
-------------------------------------
> I guess I was not clear enough. I'm talking about aborting the event in the
> generated method
Yes, I understand. I still don't think what you are proposing to do is an
improvement to how it works now.
You are going to take away the ability of using the no-arg onActivate method as
general activation setup when you use the @PageActivationContext. Users such as
Alexander are going to have broken apps when they're code that depends on the
existing behavior stops getting called.
I don't think adding a parameter to the annotation is right either... if you
want to use both the annotation and the no-arg onActivate then check for the
parameter to be initialized in the no-arg onActivate.
> @PageActivationContext should case the activate event to be aborted
> -------------------------------------------------------------------
>
> Key: TAP5-1373
> URL: https://issues.apache.org/jira/browse/TAP5-1373
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.2.4
> Reporter: Igor Drobiazko
> Assignee: Igor Drobiazko
>
> Currently it is not possible to have both: a field annotated with
> @PageActivationContext and a no-args onActivate() method. The generated
> method doesn't abort the event, so that the no-args activation method is
> called afterwards. This behaviour overrides the activation context retrieved
> from the URL.
> public class Foo {
> @PageActivationContext
> private String bar;
> void onActivate() {
> bar = "baz";
> }
> }
> The generated method should store a "true" result in order to abort the event.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
