[
https://issues.apache.org/jira/browse/TAP5-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983492#action_12983492
]
Donny Nadolny commented on TAP5-1416:
-------------------------------------
One of the places where this should be documented is
http://tapestry.apache.org/configuration.html
Right now it says "If "true", then all JavaScript libraries required for a
particular page render will be combined into a single request (the contents of
the libraries are dynamically combined by Tapestry). Defaults to "true" in
production mode."
But that's not correct. Instead, all JavaScript libraries in a stack will be
combined with the other libraries in that stack. JavaScript libraries not in a
stack are not combined (at the moment - I think it might still be a good idea
to do, since they'll usually be small)
> Combine scripts does not work
> -----------------------------
>
> Key: TAP5-1416
> URL: https://issues.apache.org/jira/browse/TAP5-1416
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.2.4
> Reporter: Donny Nadolny
> Priority: Minor
>
> In any Tapestry 5.2.4 in production mode, multiple javascript files are
> supposed to be combined in to one virtual file to reduce the number of HTTP
> requests on the page. This bug (regression from 5.1.0.5) is that this doesn't
> happen, even if combine scripts is explicitly enabled.
> To reproduce, take any application (eg the maven quickstart one) and add the
> following line to the page:
> @IncludeJavaScriptLibrary({"context:test.js", "context:test2.js"})
> public class Index {
> //rest of page
> }
> In src/main/webapp added two files, test.js and test2.js
> In AppModule, make sure that production mode is not set to false.
> In 5.1.0.5, going to that page would result in one virtual asset for the
> javascript files. In 5.2.4, they are all served separately.
> Additional details:
> This happens even if SymbolConstants.COMBINE_SCRIPTS is explicitly set to
> true in the AppModule (according to the docs, it should default to true if
> production mode is true).
> This also happens using the new @Import annotation instead of
> @IncludeJavaScriptLibrary
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
