[
https://issues.apache.org/jira/browse/TAP5-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135882#comment-13135882
]
Hudson commented on TAP5-1483:
------------------------------
Integrated in tapestry-trunk-freestyle #610 (See
[https://builds.apache.org/job/tapestry-trunk-freestyle/610/])
TAP5-1483 Make configuration knob to use of BaseURLSource to build fully
qualified Assets URL, defaults to false
mlusetti :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1189123
Files :
*
/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/SymbolConstants.java
*
/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/AssetPathConstructorImpl.java
*
/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/assets/AssetsModule.java
*
/tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ClasspathAssetAliasManagerImplTest.java
*
/tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ContextAssetFactoryTest.java
*
/tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/test/InternalBaseTestCase.java
> AssetPathConstructorImpl should use BaseURLSource
> -------------------------------------------------
>
> Key: TAP5-1483
> URL: https://issues.apache.org/jira/browse/TAP5-1483
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2
> Reporter: Jonathan Barker
> Assignee: Massimo Lusetti
> Priority: Minor
> Attachments: patch.txt
>
>
> Asset paths should be constructed using the BaseURLSource rather than just
> the request context path to match the behavior for pages, etc. Currently, to
> get absolute URL's including domain portion for assets, you need to override
> the AssetPathConstructor.
> Apart from contributing the BaseURLSource, it is a small change from:
> StringBuilder builder = new StringBuilder(request.getContextPath());
> to
> StringBuilder builder = new
> StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
> builder.append(request.getContextPath());
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
