Codestyle: Please use protected for methods and variables in service classes
----------------------------------------------------------------------------

                 Key: TAP5-1761
                 URL: https://issues.apache.org/jira/browse/TAP5-1761
             Project: Tapestry 5
          Issue Type: Improvement
    Affects Versions: 5.3
            Reporter: Michael Wyraz


Most service classes use "private" for instance variables, and methods. This 
makes it almost impossible to extend them.

Example:
- TAP5-1148

Other example:
I decorated ComponentClassResolver to convert PageNames to page-names in URLs 
which is more seo friendly. Almost everything worked except events because 
there's a fixed pattern in ComponentEventLinkEncoderImpl.
There's no way to decorate/extend this class to change the behaviour of this 
pattern or the decodeComponentEventLinkRequest because one would need access to 
all those private things to override the method.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to