[
https://issues.apache.org/jira/browse/TAP5-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533244#comment-13533244
]
Hudson commented on TAP5-1868:
------------------------------
Integrated in tapestry-trunk-freestyle #977 (See
[https://builds.apache.org/job/tapestry-trunk-freestyle/977/])
TAP5-1868: Fix the caching rules so that compressed resources are not sent
to clients that don't support compression (Revision
3679e3edb891b51e1242e0842063b9517027eeee)
Mark TAP5-1868 as fixed (Revision d6fa00a99b3b2f3cfce94ffbfe80cc3854d5cc09)
Result = FAILURE
hlship :
Files :
*
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/SRSCachingInterceptor.java
*
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/SRSCompressedCachingInterceptor.java
hlship :
Files :
* 54_RELEASE_NOTES.txt
> SRSCachingInterceptor returns compressed version of asset for all clients
> once it was compressed for some client
> ----------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1868
> URL: https://issues.apache.org/jira/browse/TAP5-1868
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: Dmitry Gusev
> Assignee: Howard M. Lewis Ship
> Labels: fixed-in-5.4-js-rewrite
> Fix For: 5.3.5, 5.4
>
>
> Cache lookup ignores StreamableResourceProcessing argument.
> public class SRSCachingInterceptor implements StreamableResourceSource,
> InvalidationListener
> {
> ...
> public StreamableResource getStreamableResource(Resource baseResource,
> StreamableResourceProcessing processing, ResourceDependencies dependencies)
> throws IOException
> {
> if (processing == StreamableResourceProcessing.FOR_AGGREGATION)
> {
> return delegate.getStreamableResource(baseResource, processing,
> dependencies);
> }
> StreamableResource result = TapestryInternalUtils.getAndDeref(cache,
> baseResource);
> if (result == null)
> {
> result = delegate.getStreamableResource(baseResource, processing,
> dependencies);
> if (isCacheable(result))
> {
> dependencies.addDependency(baseResource);
> cache.put(baseResource, new
> SoftReference<StreamableResource>(result));
> }
> }
> return result;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
