[ 
https://issues.apache.org/jira/browse/TAP5-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674589#comment-13674589
 ] 

Howard M. Lewis Ship commented on TAP5-2063:
--------------------------------------------

There is a critical problem with this fix.

I have an application that uses activation request parameters, and page links 
that work by setting the value of an ARP directly (it's for paginating a list, 
so there's an @ActivationRequestParameter on a page field, and PageLinks that 
set the page as a parameter.

Because of the multi-valued support added with this bug, the final URL has two 
values for page: the current page, and the requested page. This makes it 
impossible to navigate to a different page.

                
> Add support for multivalued parameters in Link
> ----------------------------------------------
>
>                 Key: TAP5-2063
>                 URL: https://issues.apache.org/jira/browse/TAP5-2063
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>            Reporter: Alejandro Scandroli
>            Assignee: Kalle Korhonen
>             Fix For: 5.3.7, 5.4
>
>         Attachments: TAP5-2063_1.patch
>
>
> Request.java has support for multivalued parameters but there is no way to 
> add more than one parameter with the same name to the Link. Instead of 
> throwing an IllegalArgumentException when the link already has a parameter 
> with the same name Link.addParameter should add it to the URL as a 
> multivalued parameter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to