Updated Branches: refs/heads/master c18e1199e -> 525cf43ed
Correct the jQuery element visibility check Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/525cf43e Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/525cf43e Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/525cf43e Branch: refs/heads/master Commit: 525cf43ed5c651d372db2c8a6231a85734a69586 Parents: c18e119 Author: Howard M. Lewis Ship <[email protected]> Authored: Wed Jun 5 14:52:11 2013 -0700 Committer: Howard M. Lewis Ship <[email protected]> Committed: Wed Jun 5 14:52:11 2013 -0700 ---------------------------------------------------------------------- .../org/apache/tapestry5/t5-core-dom-jquery.coffee | 4 +--- .../apache/tapestry5/t5-core-dom-prototype.coffee | 2 -- 2 files changed, 1 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/525cf43e/tapestry-core/src/main/coffeescript/org/apache/tapestry5/t5-core-dom-jquery.coffee ---------------------------------------------------------------------- diff --git a/tapestry-core/src/main/coffeescript/org/apache/tapestry5/t5-core-dom-jquery.coffee b/tapestry-core/src/main/coffeescript/org/apache/tapestry5/t5-core-dom-jquery.coffee index 86c09b4..a55e45e 100644 --- a/tapestry-core/src/main/coffeescript/org/apache/tapestry5/t5-core-dom-jquery.coffee +++ b/tapestry-core/src/main/coffeescript/org/apache/tapestry5/t5-core-dom-jquery.coffee @@ -309,11 +309,9 @@ define ["underscore", "./utils", "jquery", "./events"], (_, utils, $, events) -> # Returns true if this element is visible, false otherwise. This does not check to see if all containers of the # element are visible. visible: -> - @$.css("display") isnt "hidden" + @$.css("display") isnt "none" # Returns true if this element is visible, and all parent elements are also visible, up to the document body. - # - # Note that in Tapestry 5.3, the search would stop at the nearest form element, not the document body. deepVisible: -> cursor = this while cursor http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/525cf43e/tapestry-core/src/main/coffeescript/org/apache/tapestry5/t5-core-dom-prototype.coffee ---------------------------------------------------------------------- diff --git a/tapestry-core/src/main/coffeescript/org/apache/tapestry5/t5-core-dom-prototype.coffee b/tapestry-core/src/main/coffeescript/org/apache/tapestry5/t5-core-dom-prototype.coffee index 85d1f97..9bd01a1 100644 --- a/tapestry-core/src/main/coffeescript/org/apache/tapestry5/t5-core-dom-prototype.coffee +++ b/tapestry-core/src/main/coffeescript/org/apache/tapestry5/t5-core-dom-prototype.coffee @@ -348,8 +348,6 @@ define ["underscore", "./utils", "./events", "prototype"], (_, utils, events) -> @element.visible() # Returns true if this element is visible, and all parent elements are also visible, up to the document body. - # - # Note that in Tapestry 5.3, the search would stop at the nearest form element, not the document body. deepVisible: -> cursor = this while cursor
