Updated Branches: refs/heads/master bcd3648bf -> 0a78cab9e
Slight change to how the floating console is enabled Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/4e2e8cf9 Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/4e2e8cf9 Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/4e2e8cf9 Branch: refs/heads/master Commit: 4e2e8cf9956ec265509f02452f40e453aabd51c2 Parents: bcd3648 Author: Howard M. Lewis Ship <[email protected]> Authored: Thu Sep 5 09:36:45 2013 -0700 Committer: Howard M. Lewis Ship <[email protected]> Committed: Thu Sep 5 09:36:45 2013 -0700 ---------------------------------------------------------------------- 54_RELEASE_NOTES.txt | 4 +++- .../main/coffeescript/META-INF/modules/t5/core/console.coffee | 2 +- .../org/apache/tapestry5/integration/app1/components/Border.tml | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4e2e8cf9/54_RELEASE_NOTES.txt ---------------------------------------------------------------------- diff --git a/54_RELEASE_NOTES.txt b/54_RELEASE_NOTES.txt index 0b05bd4..c6e4669 100644 --- a/54_RELEASE_NOTES.txt +++ b/54_RELEASE_NOTES.txt @@ -154,7 +154,9 @@ intended for use in development. The floating console has also been extended with an improved UI and the ability to filter the content shown. In development and testing it can be desirable to have the floating console always visible; in that case, add the attribute -`data-floating-console="true"` to the `<body>` element. +`data-floating-console="enabled"` to the `<body>` element. However, the floating console can sometimes obscure page +content and interfere with tests; `data-floating-console="invisible"` will enable the console, but keep it hidden; the +messages written to the console will be visible in the page source. ## Form.clientValidation parameter http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4e2e8cf9/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee ---------------------------------------------------------------------- diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee index 63d765c..ca44573 100644 --- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee +++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee @@ -39,7 +39,7 @@ define ["./dom", "underscore", "./bootstrap"], consoleAttribute = dom.body.attribute "data-floating-console" - forceFloating = consoleAttribute? + forceFloating = (consoleAttribute is "enabled") or (consoleAttribute is "invisible") button = (action, icon, label, disabled = false) -> """ <button data-action="#{action}" class="btn btn-default btn-mini"> http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4e2e8cf9/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/components/Border.tml ---------------------------------------------------------------------- diff --git a/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/components/Border.tml b/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/components/Border.tml index 5237999..66e0fe0 100644 --- a/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/components/Border.tml +++ b/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/components/Border.tml @@ -3,7 +3,7 @@ <head> <title>Tapestry Integration Test Application</title> </head> -<body data-floating-console="true"> +<body data-floating-console="enabled"> <div class="navbar navbar-inverse navbar-static-top" role="navigation"> <div class="container">
