[
https://issues.apache.org/jira/browse/TAP5-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082776#comment-14082776
]
Hudson commented on TAP5-1481:
------------------------------
ABORTED: Integrated in tapestry-trunk-freestyle #1292 (See
[https://builds.apache.org/job/tapestry-trunk-freestyle/1292/])
TAP5-1481: In production mode, component event requests that reference an
unknown component should respond with a 404 (hlship: rev
d9b3813a09c0d685b28b36192f578b01744af725)
*
tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app5/services/AppModule.groovy
*
tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app5/ProductionModeTests.groovy
*
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PageRenderDispatcher.java
*
tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ComponentEventDispatcherTest.java
* tapestry-core/src/test/conf/testng.xml
* tapestry-core/src/main/java/org/apache/tapestry5/modules/TapestryModule.java
*
tapestry-core/src/main/java/org/apache/tapestry5/internal/InternalConstants.java
*
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ComponentEventRequestHandlerImpl.java
*
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ComponentEventDispatcher.java
* tapestry-core/src/main/java/org/apache/tapestry5/internal/structure/Page.java
*
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ProductionModeUnknownComponentFilter.java
> In production mode, component event requests that reference an unknown
> component should respond with a 404
> ----------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1481
> URL: https://issues.apache.org/jira/browse/TAP5-1481
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.2
> Reporter: Anton Litvinenko
> Assignee: Howard M. Lewis Ship
> Fix For: 5.4
>
>
> when an embedded component cannot be found by id, then
> ComponentPageElementImpl throws a TapestryException at line 841 for 5.1.0.5
> (UnknownValueException for 5.2.4).
> I suggest throwing a special kind of exception in such case (e.g.
> EmbeddedComponentNotFoundException or ComponentNotFoundException), so that
> application would be able to handle such cases separately (e.g. by serving a
> 404 error page).
> Particular use-case: google indexing bot cached a tapestry page and tries
> indexing links that are included on this page. If links are actionlinks, then
> they include id of the component. When one changes the id of the component
> (or renames the component), then the "old" link doesn't work anymore as it
> contains old id of the component -> google indexing bot is served with
> Tapestry error page (which is a typical page). Instead, it makes sense to
> send a 404 error as result and let google bot know that there is no such
> resource anymore.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
