[
https://issues.apache.org/jira/browse/TAP5-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547830#comment-14547830
]
Hudson commented on TAP5-2479:
------------------------------
ABORTED: Integrated in tapestry-trunk-freestyle #1430 (See
[https://builds.apache.org/job/tapestry-trunk-freestyle/1430/])
TAP5-2479: build the session attribute key only if there is an active session
(jochen.kemnade: rev 47e20f4c7e3447d2486f6f2921ddbb0de04b70be)
*
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SessionApplicationStatePersistenceStrategy.java
> Improvement of SessionApplicationStatePersistenceStrategy
> ---------------------------------------------------------
>
> Key: TAP5-2479
> URL: https://issues.apache.org/jira/browse/TAP5-2479
> Project: Tapestry 5
> Issue Type: Improvement
> Reporter: Maria Fedotova
> Priority: Trivial
> Labels: patch
> Fix For: 5.4
>
> Attachments: TAP5-2479.patch
>
>
> This patch is little improvement in method exists of
> SessionApplicationStatePersistenceStrategy.
> {code}
> public <T> boolean exists(Class<T> ssoClass)
> {
> String key = buildKey(ssoClass);
> Session session = request.getSession(false);
> return session != null && session.getAttribute(key) != null;
> }
> {code}
> We changed the code so that the key is built only when the session is not
> null.
> This code didn't have effect on time per request, but I think it's useful.
> Thank [~mihasik] for the idea.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
