[ 
https://issues.apache.org/jira/browse/TAP5-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594028#comment-14594028
 ] 

Hudson commented on TAP5-2029:
------------------------------

ABORTED: Integrated in tapestry-trunk-freestyle #1447 (See 
[https://builds.apache.org/job/tapestry-trunk-freestyle/1447/])
Partial fix for TAP5-2029. (thiagohp: rev 
177dc5c3acc600d20796ae0bbd7d5226d76bbe21)
* 
plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassImpl.java
TAP5-2029: a best-effort attempt to deal with generic methods and their 
(thiagohp: rev 72334aa632d6ccade195af45014f7903fc0765fa)
* 
plastic/src/external/java/org/apache/tapestry5/internal/plastic/asm/tree/MethodNode.java
* 
plastic/src/main/java/org/apache/tapestry5/internal/plastic/PlasticClassImpl.java
* 
tapestry-ioc/src/test/groovy/ioc/specs/MethodInvocationGetAnnotationSpec.groovy
* tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/AdviceModule.java


> Copy annotations from service implementation to proxy (was JPA annotations 
> expose implementation details in service interfaces)
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-2029
>                 URL: https://issues.apache.org/jira/browse/TAP5-2029
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3.6, 5.4
>            Reporter: John Coleman
>            Assignee: Thiago H. de Paula Figueiredo
>            Priority: Minor
>              Labels: month-of-tapestry
>         Attachments: 
> 0001-TAP5-2029-Test-case-involving-generic-interface.patch
>
>
> The commit after and persistence context annotations are required on the 
> service interface definition thereby exposing internal implementation details 
> (see below example from docs). Details of implementation should be hidden at 
> the interface level, both these annotations break the rule.
> Perhaps this code could appear in the Impl classes, or be provided in 
> configuration somehow?
> public interface UserDAO {
>    @CommitAfter
>    @PersistenceContext(unitName = "DemoUnit")
>    void add(User user);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to