[ 
https://issues.apache.org/jira/browse/TAP5-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949446#comment-14949446
 ] 

Thiago H. de Paula Figueiredo commented on TAP5-2508:
-----------------------------------------------------

Hello, [~jkemnade]!

I'm not overly familiar either, but I did had to learn parts of it for 
TAP5-2029 (copying service annotations to proxies). I took a look at your patch 
and I couldn't see anything that looks risky. If you run the test suite and no 
tests fail, I'd suggest you to go ahead and commit it. And thanks for working 
on this issue. :)

> Page activation method not always called since t54-beta33
> ---------------------------------------------------------
>
>                 Key: TAP5-2508
>                 URL: https://issues.apache.org/jira/browse/TAP5-2508
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: plastic, tapestry-core
>    Affects Versions: 5.4
>            Reporter: Chris Poulsen
>              Labels: 54_release_prerequisite, patch
>         Attachments: 
> 0001-TAP5-2508-methods-with-default-visibility-cannot-be-.patch, 
> t54-activate.zip
>
>
> Hi, 
> I decided to try upgrading an app from t54-beta-26 to the latest public beta. 
> Most things seem to work, but I noticed changed behavior with onActivate 
> methods in some of our classes.
> We have a base page with the following:
> @OnEvent( ACTIVATE )
> void activate( EventContext ec)
> and an extending page with:
> @OnEvent( ACTIVATE ) 
> Object activate( EventContext ec ) 
> In beta-26 (and before) the methods are called in the following order:
> 1) Base activate
> 2) Extending page activate
> In beta-33 and newer only the Base activate is called.
> I'm attaching a sample project where one can play with the versions and see 
> the differences in the console when requesting the index page.
> Also when creating the sample project i noticed that PageLink (to login in 
> Layout.tml) fails if Login page is missing in beta-33 while it has no problem 
> with pointing to a deleted page in beta-36.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to