[
https://issues.apache.org/jira/browse/TAP5-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jochen Kemnade updated TAP5-1733:
---------------------------------
Labels: bulk-close-candidate (was: exception-handling)
This issue affects an old version of Tapestry that is not actively developed
anymore, and is therefore prone to be bulk-closed in the near future.
If the issue still persists with the most recent version of Tapestry (currently
5.4.0, available from Maven Central), please update it as soon as possible and
add '5.4.0') to the issue's affected versions.
> Throw bespoke exceptions so they may be more easily identified by Error
> Handlers
> --------------------------------------------------------------------------------
>
> Key: TAP5-1733
> URL: https://issues.apache.org/jira/browse/TAP5-1733
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Priority: Minor
> Labels: bulk-close-candidate
>
> Two exceptions in particular tend to be thrown prolifically by live sites
> when they are crawled by robots. They are:
> - java.lang.RuntimeException: Forms require that the request method be POST
> and that the t:formdata query parameter have values.
> - java.lang.IllegalArgumentException: Input string 'XXX' is not valid; the
> character 'X' at position X is not valid.
> To save needless reporting of benign errors (and to prevent the error logs
> from filling up) these exceptions are usually ignored by implementing Error
> Handlers. But the ErrorHandler has to currently check the exception message:
> if (e.getMessage().contains("Forms require that the request method be POST"))
> {
> doIgnore();
> }
> which is both brittle and nasty. Instead it'd be great if Tapestry could
> throw some bespoke exceptions so the above could be re-written as:
> if (e instanceof FormsRequirePostException) {
> doIngore();
> }
> Email thread below:
> http://tapestry.1045711.n5.nabble.com/Safari-for-example-browser-history-and-form-exception-td4942074.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
