[ 
https://issues.apache.org/jira/browse/TAP5-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158858#comment-15158858
 ] 

Barry Books commented on TAP5-2099:
-----------------------------------

That test case fails because it calls the set method and then calls the get 
method and expects it to return what it just set and the code I proposed will 
not pass that test because the set method does nothing. That test will not pass 
with the current implementation either. Whether that test is valid depends on 
what you think setting a literal should do.

It's possible to make that test pass by returning false from isInvariant, 
adding a local variable and using it for the get and set methods but I'm not 
sure that's the correct functionality for a literal. A literal should be 
invariant and should always return the same value. The same goes for a Symbol. 

Personally I think the test should check that the value returned by the get 
should not change.



> Update parameters bound to literal: or symbol: from a mixin
> -----------------------------------------------------------
>
>                 Key: TAP5-2099
>                 URL: https://issues.apache.org/jira/browse/TAP5-2099
>             Project: Tapestry 5
>          Issue Type: Improvement
>    Affects Versions: 5.3.6, 5.4
>            Reporter: Lance
>              Labels: patch
>         Attachments: TAP52099-1.patch
>
>
> Currently, I cannot update a component component parameter that is 
> initialized with a literal: or symbol: binding from a mixin. If I try to 
> @BindParameter the param and change it's value, I get a "Binding %s is 
> read-only" exception (originating from AbstractBinding).
> I propose that literal and symbol bindings are sourced from a PerThreadValue 
> that can be updated by a mixin.
> My original need for this was to create a "SinglePage" mixin for the Grid 
> component which would set the rowsPerPage parameter to Integer.MAX_VALUE. I 
> can't currently do this because by default, the parameter is a symbol: 
> binding.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to