[ 
https://issues.apache.org/jira/browse/TAP5-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188880#comment-15188880
 ] 

Jochen Kemnade commented on TAP5-1803:
--------------------------------------

AFAICT, skipping the safe set check when decoding would not affect consistency. 
The encoding would still work in the same way that it does now and decoding of 
Tapestry-encoded strings would not be affected. However, it will allow us to 
use parameters that were not encoded by Tapestry.
I think that we should not change the safe set. That will probably lead to 
inconsistencies between versions. At least it will make newer Tapestry versions 
create URLs that older versions wouldn't be able to decode.

> URL encoding in ActivationRequestParameter is very strict
> ---------------------------------------------------------
>
>                 Key: TAP5-1803
>                 URL: https://issues.apache.org/jira/browse/TAP5-1803
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.1, 5.4
>            Reporter: David Canteros
>              Labels: @ActivationRequestParameter, InvalidaArgumenteException, 
> URLEncoder,
>
> The URLEncoder that perform the URL encoding process does not include the 
> following "unreserved characters" :          
>  !  ~  *  ' (  )       
> (see rfc2396 Uniform Resource Identifiers (URI): Generic Syntax, item 2.3)
>        
> Because the fix of TAP5-1768, from v5.3.1 the @ActivationRequestParameter 
> requires this enconding, which becomes incompatible with the standard.
> Thus, any URL which contains those symbols will throw an 
> InvalidaArgumenteException. Tapestry should consider that the 
> ActivationRequestParameter is a standar way of parameter sending, and the 
> parameters sent in this way probably not have the "strict" coding process of 
> the URLEncoder.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to