[
https://issues.apache.org/jira/browse/TAP5-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15293306#comment-15293306
]
ASF GitHub Bot commented on TAP5-2549:
--------------------------------------
GitHub user felixgonschorek opened a pull request:
https://github.com/apache/tapestry5/pull/7
Tap5 2549
fix and test for https://issues.apache.org/jira/browse/TAP5-2549
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/netzgut/tapestry5 TAP5-2549
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tapestry5/pull/7.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7
----
commit 28e4013bbd1693f66c9227896884928be0266245
Author: Felix Gonschorek <[email protected]>
Date: 2016-05-20T11:14:08Z
TAP5-2549: ZoneRefresh mixin should check for XHR requests - implement
fix
commit d7fd281575980f7805ece2f51cbe7b1bc9fded56
Author: Felix Gonschorek <[email protected]>
Date: 2016-05-20T11:17:56Z
TAP5-2549: ZoneRefresh mixin should check for XHR requests - add test
----
> ZoneRefresh mixin should check for XHR requests
> -----------------------------------------------
>
> Key: TAP5-2549
> URL: https://issues.apache.org/jira/browse/TAP5-2549
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.4.1
> Reporter: Felix Gonschorek
> Priority: Minor
> Labels: ajax, easyfix
>
> ZoneRefresh mixin returns always Block, even if the request is not a XHR
> request which leads to errors in the logfile.
> This happens when crawlers load the URL with normal http GET request:
> {{org.apache.tapestry5.ioc.util.UnknownValueException: A component event
> handler method returned the value <PlaceholderBlock>. Return type
> org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock
> can not be handled.}}
> Going to attach patch soon!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
