[
https://issues.apache.org/jira/browse/TAP5-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741363#comment-16741363
]
Thiago H. de Paula Figueiredo commented on TAP5-2560:
-----------------------------------------------------
Hello, [~chrispoulsen]!
I've got a report with an example (basically, creating a BeanModel in an object
with a property which implements Comparable) in which my latest fix attempt
caused an stack overflow, so I'm going to revert it. I don't have the time to
implement it yet, but I have a plan to create an interface with the
GenericUtils 5 methods, have a default implementation using GenericUtils, then
provide a way of overriding the default implementation using
java.util.ServiceLoader, since Tapestry-IoC services aren't present on the
{{beanmodel}} package. In addition, I'd create a separate Tapestry project and
JAR with an implementation using Guava for the projects the current
GenericUtils doesn't work. If I get everything right, just adding this new JAR
to the classpath will make GenericUtils use Guava instead of Tapestry's own
generics resolution code.
> Error in GenericsUtils affecting property access
> ------------------------------------------------
>
> Key: TAP5-2560
> URL: https://issues.apache.org/jira/browse/TAP5-2560
> Project: Tapestry 5
> Issue Type: Bug
> Affects Versions: 5.4.1
> Reporter: Chris Poulsen
> Assignee: Thiago H. de Paula Figueiredo
> Priority: Major
> Attachments: generics-utils.patch
>
>
> There is an error somewhere in the GenericsUtils.resolve( TypeVariable
> typeVariable, Type containingType ) method.
> It resolves some type variables to their lower bound instead of the correct
> version.
> We have model classes that uses lots of generics and in some cases tapestry
> reports that a given property expression is invalid because some lower bound
> interface does not contain the property in the expression.
> I tried to see if I could find an easy fix, but ended up running out of time
> and simply replaced the bodies of the 5 resolution methods in the
> GenericsUtils with guava reflect code and then things started working as
> expected.
> The interface setup that gives the error looks like this:
> {code}
> public interface NonTranslatableContentUnit<T extends ContentData> {
> T getContent();
> }
> public interface BinaryContentUnit<T extends BinaryContent> extends
> NonTranslatableContentUnit<T> {}
> public interface FileContentUnit extends BinaryContentUnit<FileContent> {}
> public interface ContentData {
> isEmpty();
> ...
> }
> public interface BinaryContent extends ContentData {
> String getMimeType();
> ...
> }
> public interface FileContent extends BinaryContent {}
> {code}
> Then we have a property expression on a FileContentUnit like:
> "content.mimeType" and that fails with an error that says something like
> ContentData does not have a property MimeType.
> As far as I can tell the resolve(TypeVariable, ..) method fails to do
> anything sensible if the Type of the "containing class" is not an instance of
> ParameterizedType
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
