[
https://issues.apache.org/jira/browse/TAP5-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742137#comment-16742137
]
Balázs Palcsó commented on TAP5-2606:
-------------------------------------
I agree with your approach of doing option #1.
I think the challenge is how can we stay close to the official repo of YUI
compressor, so we can benefit of future bug fixes (even though PR does not seem
to get merged too quickly, maybe there is a more active fork).
Makes sense to replace CssMinimizer on the project level with your
implementation, though on tapestry framework level it would be great if we
could somehow manage of benefiting upstream fixes and applying patches that are
very slowly getting merged.
Regarding the calc issue, isn't that addressed in the latest version at line
142?
https://github.com/yui/yuicompressor/blob/958491db9bff77fe97d3ea0b8af38953aa1f6216/src/com/yahoo/platform/yui/compressor/CssCompressor.java#L142
> Inline SVG image is broken in proudction mode, because whitespaces are removed
> ------------------------------------------------------------------------------
>
> Key: TAP5-2606
> URL: https://issues.apache.org/jira/browse/TAP5-2606
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-webresources
> Affects Versions: 5.4.4
> Reporter: Balázs Palcsó
> Priority: Major
>
> YUI CSS compressor bug causes this:
> [https://github.com/yui/yuicompressor/issues/141]
> I have raised a PR to fix that, but we can still apply my fix regardless if
> it gets merged or not:
> https://github.com/yui/yuicompressor/pull/319
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
