[
https://issues.apache.org/jira/browse/TAP5-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785817#comment-17785817
]
Ben Weidig commented on TAP5-2769:
----------------------------------
Thanks for the info and the updated PR!
I haven't used shadowed dependencies, but it sounds sensible to keep it
shadowed then.
Reducing the dependency exposure is a good idea in the mid-/long-run.
But merging your PR and doing TAP5-2767 (Gradle 8 support) should be done
first, so we gain Java 21 support.
I'm really looking forward to using 21, too ;)
> Upgrade ASM to 9.6 to allow running on Java 21
> ----------------------------------------------
>
> Key: TAP5-2769
> URL: https://issues.apache.org/jira/browse/TAP5-2769
> Project: Tapestry 5
> Issue Type: Task
> Components: plastic
> Affects Versions: 5.8.3
> Reporter: Chris Poulsen
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I have a local version where the shadowing of ASM is done by Gradle to easier
> maintain the ASM copy in the future.
> I'll create a PR with the changes on Github.
> The copied version had a single change to the ASM sources (in order to access
> the static package protected method
> {code:java}
> AnnotationNode.accept
> {code}
> .
> I did a quick hack with reflection to access it instead, there is definitely
> room for improvement there, if anyone wants to take a stab at it.
> Edit: PR https://github.com/apache/tapestry-5/pull/46
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
