Chris Poulsen created TAP5-2777:
-----------------------------------

             Summary: Update the closure compiler for better support of modern 
JavaScript
                 Key: TAP5-2777
                 URL: https://issues.apache.org/jira/browse/TAP5-2777
             Project: Tapestry 5
          Issue Type: Task
          Components: tapestry-webresources
    Affects Versions: 5.8.6
            Reporter: Chris Poulsen


A couple of years ago we encountered errors related to the closure compiler not 
understanding certain modern JavaScript constructs.

The details are sort of hazy, but IIRC the newest version(s) of the compiler 
were not just drop-in upgrades (primo 2022). We ended up with "v20210505" back 
then, it allowed our JavaScript to pass through and was still just a drop-in 
upgrade.



We have been running the following config in production for 2 years (on a bunch 
of installations) without issues, so maybe more people would benefit from this 
upgrade.
{code:java}
runtimeOnly("org.apache.tapestry:tapestry-webresources:$tapestryVersion") {
    exclude group: 'com.google.javascript'
}
runtimeOnly("com.google.javascript:closure-compiler-unshaded:v20210505") 
runtimeOnly("com.google.javascript:closure-compiler-externs:v20210505")     
{code}
Ideally the compiler support would be updated to the newest version and kept 
up-to-date, but for a low hanging fruit, this one should be a simple step.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to