Issue fixed : have some performance considerations Project: http://git-wip-us.apache.org/repos/asf/incubator-taverna-language/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-taverna-language/commit/a4c23189 Tree: http://git-wip-us.apache.org/repos/asf/incubator-taverna-language/tree/a4c23189 Diff: http://git-wip-us.apache.org/repos/asf/incubator-taverna-language/diff/a4c23189
Branch: refs/heads/master Commit: a4c23189c7a1033c6c94c6550a728857ea7d9fdf Parents: 57dd0ee Author: Menaka Madushanka <[email protected]> Authored: Sat Jul 25 03:36:18 2015 +0530 Committer: Menaka Madushanka <[email protected]> Committed: Sat Jul 25 03:36:18 2015 +0530 ---------------------------------------------------------------------- .../taverna/robundle/validator/RoValidator.java | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-taverna-language/blob/a4c23189/taverna-robundle/src/main/java/org/apache/taverna/robundle/validator/RoValidator.java ---------------------------------------------------------------------- diff --git a/taverna-robundle/src/main/java/org/apache/taverna/robundle/validator/RoValidator.java b/taverna-robundle/src/main/java/org/apache/taverna/robundle/validator/RoValidator.java index 062134a..c1dedd5 100644 --- a/taverna-robundle/src/main/java/org/apache/taverna/robundle/validator/RoValidator.java +++ b/taverna-robundle/src/main/java/org/apache/taverna/robundle/validator/RoValidator.java @@ -25,7 +25,9 @@ import java.nio.file.Path; import java.util.ArrayList; import java.util.Enumeration; import java.util.HashMap; +import java.util.HashSet; import java.util.List; +import java.util.Set; import java.util.zip.ZipEntry; import java.util.zip.ZipFile; @@ -129,15 +131,19 @@ public class RoValidator { * There are default files: mimetype and LICENSE * */ + + //FIX ME : performance ??? + Set<String> set = new HashSet<>(); + for(PathMetadata p : this.aggr){ + set.add(p.toString()); + } + for(String s : this.items){ -// s = s.toLowerCase(); - PathMetadata p = new PathMetadata(s); -// System.out.println(p); - if(s.contains("mimetype")||s.toLowerCase().contains("license")){ + if(s.contains("mimetype")||s.toLowerCase().contains("license")||s.contains(".ro")){ //This is ok and skip }else{ - if(!this.aggr.contains(p)){ + if(!set.contains(s)){ this.infoWarningList.add(p.toString()); } }
