add suggestion

Project: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/repo
Commit: 
http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/commit/d73dc200
Tree: 
http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/tree/d73dc200
Diff: 
http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/diff/d73dc200

Branch: refs/heads/master
Commit: d73dc2005d0efba59094101e9b50cea558ea7ff9
Parents: a84be44
Author: Sagar <[email protected]>
Authored: Tue Jul 5 23:41:53 2016 +0530
Committer: Sagar <[email protected]>
Committed: Tue Jul 5 23:41:53 2016 +0530

----------------------------------------------------------------------
 .../taverna/mobile/ui/workflow/WorkflowFragment.java | 15 +++++++++------
 app/src/main/res/layout/fragment_dashboard.xml       |  2 +-
 2 files changed, 10 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/blob/d73dc200/app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowFragment.java
----------------------------------------------------------------------
diff --git 
a/app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowFragment.java 
b/app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowFragment.java
index 074ef9e..f7e77d9 100644
--- 
a/app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowFragment.java
+++ 
b/app/src/main/java/org/apache/taverna/mobile/ui/workflow/WorkflowFragment.java
@@ -54,7 +54,7 @@ public class WorkflowFragment extends Fragment implements 
WorkflowMvpView,
         RecyclerItemClickListner.OnItemClickListener {
     public final String LOG_TAG = getClass().getSimpleName();
 
-    @BindView(R.id.rvDashboard)
+    @BindView(R.id.rv_workflows)
     RecyclerView mRecyclerView;
 
     @BindView(R.id.progress_circular)
@@ -129,11 +129,14 @@ public class WorkflowFragment extends Fragment implements 
WorkflowMvpView,
             @Override
             public void onRefresh() {
                 if (mConnectionInfo.isConnectingToInternet()) {
-                    if (mSwipeRefresh.isRefreshing()) {
-                        mPageNumber = 1;
-                        mWorkflowPresenter.loadAllWorkflow(mPageNumber);
-                        Log.d(LOG_TAG, "Swipe Refresh");
-                    }
+
+                    mPageNumber = 1;
+                    mWorkflowPresenter.loadAllWorkflow(mPageNumber);
+
+                    mSwipeRefresh.setRefreshing(true);
+
+                    Log.d(LOG_TAG, "Swipe Refresh");
+
                 } else {
                     Log.d(LOG_TAG, "NO Internet Connection");
                     showErrorSnackBar();

http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/blob/d73dc200/app/src/main/res/layout/fragment_dashboard.xml
----------------------------------------------------------------------
diff --git a/app/src/main/res/layout/fragment_dashboard.xml 
b/app/src/main/res/layout/fragment_dashboard.xml
index f3b691a..06e4781 100644
--- a/app/src/main/res/layout/fragment_dashboard.xml
+++ b/app/src/main/res/layout/fragment_dashboard.xml
@@ -27,7 +27,7 @@
             android:layout_height="match_parent">
 
         <android.support.v7.widget.RecyclerView
-                android:id="@+id/rvDashboard"
+                android:id="@+id/rv_workflows"
                 android:layout_width="match_parent"
                 android:layout_height="match_parent"
                 android:clipToPadding="false"

Reply via email to