fix pmd issues
Project: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/commit/89364c29 Tree: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/tree/89364c29 Diff: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/diff/89364c29 Branch: refs/heads/master Commit: 89364c2949e52e5f9384998a6f48399b723ac54b Parents: 5d86283 Author: Sagar <[email protected]> Authored: Fri Jan 26 19:02:59 2018 +0530 Committer: Sagar <[email protected]> Committed: Fri Jan 26 19:02:59 2018 +0530 ---------------------------------------------------------------------- .../taverna/mobile/ui/login/LoginFragment.java | 20 ++++++++++---------- .../ui/playerlogin/PlayerLoginFragment.java | 18 +++++++++--------- 2 files changed, 19 insertions(+), 19 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/blob/89364c29/app/src/main/java/org/apache/taverna/mobile/ui/login/LoginFragment.java ---------------------------------------------------------------------- diff --git a/app/src/main/java/org/apache/taverna/mobile/ui/login/LoginFragment.java b/app/src/main/java/org/apache/taverna/mobile/ui/login/LoginFragment.java index 33b7bb4..52cdf50 100644 --- a/app/src/main/java/org/apache/taverna/mobile/ui/login/LoginFragment.java +++ b/app/src/main/java/org/apache/taverna/mobile/ui/login/LoginFragment.java @@ -19,6 +19,12 @@ package org.apache.taverna.mobile.ui.login; +import org.apache.taverna.mobile.R; +import org.apache.taverna.mobile.data.DataManager; +import org.apache.taverna.mobile.data.local.PreferencesHelper; +import org.apache.taverna.mobile.ui.DashboardActivity; +import org.apache.taverna.mobile.utils.ConnectionInfo; + import android.app.ProgressDialog; import android.content.Intent; import android.os.Bundle; @@ -35,12 +41,6 @@ import android.view.WindowManager; import android.widget.CheckBox; import android.widget.EditText; -import org.apache.taverna.mobile.R; -import org.apache.taverna.mobile.ui.DashboardActivity; -import org.apache.taverna.mobile.data.DataManager; -import org.apache.taverna.mobile.data.local.PreferencesHelper; -import org.apache.taverna.mobile.utils.ConnectionInfo; - import butterknife.BindView; import butterknife.ButterKnife; import butterknife.OnClick; @@ -118,7 +118,7 @@ public class LoginFragment extends Fragment implements LoginMvpView, View.OnFocu private void validateEmail() { - if (mEditTextEmail.getText().toString().trim().isEmpty()) { + if (mEditTextEmail.getText().toString().trim().length() > 0) { mTextInputEmail.setError(getString(R.string.err_login_email)); } else { @@ -131,7 +131,7 @@ public class LoginFragment extends Fragment implements LoginMvpView, View.OnFocu private void validatePassword() { - if (mEditTextPassword.getText().toString().trim().isEmpty()) { + if (mEditTextPassword.getText().toString().trim().length() > 0) { mTextInputPassword.setError(getString(R.string.err_login_password)); } else { @@ -145,8 +145,8 @@ public class LoginFragment extends Fragment implements LoginMvpView, View.OnFocu @OnClick(R.id.bLogin) public void login(View v) { if (ConnectionInfo.isConnectingToInternet(getContext())) { - if (!mEditTextEmail.getText().toString().trim().isEmpty() && !mEditTextPassword - .getText().toString().trim().isEmpty()) { + if (mEditTextEmail.getText().toString().trim().length() > 0 && mEditTextPassword + .getText().toString().trim().length() > 0) { mLoginPresenter.login(mEditTextEmail.getText().toString().trim(), mEditTextPassword.getText().toString().trim(), mCheckBoxRemember http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/blob/89364c29/app/src/main/java/org/apache/taverna/mobile/ui/playerlogin/PlayerLoginFragment.java ---------------------------------------------------------------------- diff --git a/app/src/main/java/org/apache/taverna/mobile/ui/playerlogin/PlayerLoginFragment.java b/app/src/main/java/org/apache/taverna/mobile/ui/playerlogin/PlayerLoginFragment.java index 7123e6e..6c78ca8 100644 --- a/app/src/main/java/org/apache/taverna/mobile/ui/playerlogin/PlayerLoginFragment.java +++ b/app/src/main/java/org/apache/taverna/mobile/ui/playerlogin/PlayerLoginFragment.java @@ -19,6 +19,11 @@ package org.apache.taverna.mobile.ui.playerlogin; +import org.apache.taverna.mobile.R; +import org.apache.taverna.mobile.data.DataManager; +import org.apache.taverna.mobile.data.local.PreferencesHelper; +import org.apache.taverna.mobile.utils.ConnectionInfo; + import android.content.Context; import android.os.Bundle; import android.support.annotation.Nullable; @@ -34,11 +39,6 @@ import android.view.WindowManager; import android.widget.CheckBox; import android.widget.EditText; -import org.apache.taverna.mobile.R; -import org.apache.taverna.mobile.data.DataManager; -import org.apache.taverna.mobile.data.local.PreferencesHelper; -import org.apache.taverna.mobile.utils.ConnectionInfo; - import butterknife.BindView; import butterknife.ButterKnife; import butterknife.OnClick; @@ -119,8 +119,8 @@ public class PlayerLoginFragment extends Fragment implements PlayerLoginMvpView, @OnClick(R.id.bLogin) public void login(View v) { if (ConnectionInfo.isConnectingToInternet(getContext())) { - if (!mEditTextEmail.getText().toString().trim().isEmpty() && !mEditTextPassword - .getText().toString().trim().isEmpty()) { + if (mEditTextEmail.getText().toString().trim().length() > 0 && mEditTextPassword + .getText().toString().trim().length() > 0) { mPlayerLoginPresenter.playerLogin(mEditTextEmail.getText().toString().trim(), mEditTextPassword.getText().toString().trim(), mCheckBoxRemember @@ -165,7 +165,7 @@ public class PlayerLoginFragment extends Fragment implements PlayerLoginMvpView, private void validateEmail() { - if (mEditTextEmail.getText().toString().trim().isEmpty()) { + if (mEditTextEmail.getText().toString().trim().length() > 0) { mTextInputEmail.setError(getString(R.string.err_login_email)); } else { mTextInputEmail.setError(null); @@ -182,7 +182,7 @@ public class PlayerLoginFragment extends Fragment implements PlayerLoginMvpView, } private void validatePassword() { - if (mEditTextPassword.getText().toString().trim().isEmpty()) { + if (mEditTextPassword.getText().toString().trim().length() > 0) { mTextInputPassword.setError(getString(R.string.err_login_password)); } else { mTextInputPassword.setError(null);
